GNU bug report logs - #74848
[PATCH] calendar: check for presuppositions in `calendar-date-is-valid-p'

Previous Next

Full log

View this message in rfc822 format

From: Richard Lawrence <rwl <at> recursewithless.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 74848 <at> debbugs.gnu.org
Subject: bug#74848: [PATCH] calendar: check for presuppositions in `calendar-date-is-valid-p'
Date: Sat, 14 Dec 2024 13:19:19 +0100

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

> The commit log message should include the file and the function(s)
> where the changes are done, as well as a short description of the
> changes.  See CONTRIBUTE for more details, and see "git log" for the
> examples of how we format commit log messages.  Please don't forget to
> mention the bug number in the commit log message.

Woops, sorry, I did look at that file but I guess I missed that. New
patch attached.

> P.S. I presume you've run the relevant parts of the test suite and
> verified that they still succeed.  If not, please do.

Oddly enough, unless I'm missing something, there don't seem to be any
tests for calendar.el. There *are* a bunch of test files in
test/lisp/calendar, but they are all for other files, not for
calendar.el itself. The attached patch includes a new test file with a
basic test of the predicate, and make check reveals no relevant
problems.

Best,
Richard

[0001-Check-for-presuppositions-in-calendar-date-is-valid-.patch (text/patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.