GNU bug report logs - #74848
[PATCH] calendar: check for presuppositions in `calendar-date-is-valid-p'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74848 in the body.
You can then email your comments to 74848 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Richard Lawrence <rwl <at> recursewithless.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] calendar: check for presuppositions in
 `calendar-date-is-valid-p'
Date: Fri, 13 Dec 2024 13:02:36 +0100

[Message part 1 (text/plain, inline)]

Tags: patch

Tags: patch

Hi all,

Here is a patch to make calendar-date-is-valid-p return nil, instead of
signaling an error, when it is passed a value that isn't a list of the
form (MONTH DAY YEAR).

This (a) makes the function a proper predicate, as its name suggests,
which (b) is necessary in some of the new iCalendar code I've been
working on (to be posted soon).

(I've deleted the build information about the Emacs I'm sending from,
because it is different from Emacs master, against which the patch is
formatted.)

This is my first time submitting a patch with submit-emacs-patch, so
please let me know if I did anything wrong.

Thanks!
Richard

[0001-calendar-check-for-presuppositions-in-calendar-date-.patch (text/patch, attachment)]

Message #8 received at 74848 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Richard Lawrence <rwl <at> recursewithless.net>
Cc: 74848 <at> debbugs.gnu.org
Subject: Re: bug#74848: [PATCH] calendar: check for presuppositions in
 `calendar-date-is-valid-p'
Date: Sat, 14 Dec 2024 13:06:00 +0200

> From: Richard Lawrence <rwl <at> recursewithless.net>
> Date: Fri, 13 Dec 2024 13:02:36 +0100
> 
> Here is a patch to make calendar-date-is-valid-p return nil, instead of
> signaling an error, when it is passed a value that isn't a list of the
> form (MONTH DAY YEAR).
> 
> This (a) makes the function a proper predicate, as its name suggests,
> which (b) is necessary in some of the new iCalendar code I've been
> working on (to be posted soon).

Thanks.

> This is my first time submitting a patch with submit-emacs-patch, so
> please let me know if I did anything wrong.

The commit log message should include the file and the function(s)
where the changes are done, as well as a short description of the
changes.  See CONTRIBUTE for more details, and see "git log" for the
examples of how we format commit log messages.  Please don't forget to
mention the bug number in the commit log message.

P.S. I presume you've run the relevant parts of the test suite and
verified that they still succeed.  If not, please do.

Message #11 received at 74848 <at> debbugs.gnu.org (full text, mbox):

From: Richard Lawrence <rwl <at> recursewithless.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 74848 <at> debbugs.gnu.org
Subject: Re: bug#74848: [PATCH] calendar: check for presuppositions in
 `calendar-date-is-valid-p'
Date: Sat, 14 Dec 2024 13:19:19 +0100

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

> The commit log message should include the file and the function(s)
> where the changes are done, as well as a short description of the
> changes.  See CONTRIBUTE for more details, and see "git log" for the
> examples of how we format commit log messages.  Please don't forget to
> mention the bug number in the commit log message.

Woops, sorry, I did look at that file but I guess I missed that. New
patch attached.

> P.S. I presume you've run the relevant parts of the test suite and
> verified that they still succeed.  If not, please do.

Oddly enough, unless I'm missing something, there don't seem to be any
tests for calendar.el. There *are* a bunch of test files in
test/lisp/calendar, but they are all for other files, not for
calendar.el itself. The attached patch includes a new test file with a
basic test of the predicate, and make check reveals no relevant
problems.

Best,
Richard

[0001-Check-for-presuppositions-in-calendar-date-is-valid-.patch (text/patch, attachment)]

Message #16 received at 74848-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Richard Lawrence <rwl <at> recursewithless.net>
Cc: 74848-done <at> debbugs.gnu.org
Subject: Re: bug#74848: [PATCH] calendar: check for presuppositions in
 `calendar-date-is-valid-p'
Date: Sat, 14 Dec 2024 14:45:47 +0200

> From: Richard Lawrence <rwl <at> recursewithless.net>
> Cc: 74848 <at> debbugs.gnu.org
> Date: Sat, 14 Dec 2024 13:19:19 +0100
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > The commit log message should include the file and the function(s)
> > where the changes are done, as well as a short description of the
> > changes.  See CONTRIBUTE for more details, and see "git log" for the
> > examples of how we format commit log messages.  Please don't forget to
> > mention the bug number in the commit log message.
> 
> Woops, sorry, I did look at that file but I guess I missed that. New
> patch attached.
> 
> > P.S. I presume you've run the relevant parts of the test suite and
> > verified that they still succeed.  If not, please do.
> 
> Oddly enough, unless I'm missing something, there don't seem to be any
> tests for calendar.el. There *are* a bunch of test files in
> test/lisp/calendar, but they are all for other files, not for
> calendar.el itself. The attached patch includes a new test file with a
> basic test of the predicate, and make check reveals no relevant
> problems.

Thanks, installed on the master branch, and closing the bug.

I needed to tweak the commit log message somewhat; please see how I
changed it and try to follow these conventions in the future.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.