GNU bug report logs - #74830
[PATCH] gnu: libcbor: Fix cross-compiling to 32-bit architecture

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#74830: closed ([PATCH] gnu: libcbor: Fix cross-compiling to
 32-bit architecture)
Date: Sun, 15 Dec 2024 22:55:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 15 Dec 2024 23:54:29 +0100
with message-id <87bjxch80q.fsf <at> gnu.org>
and subject line Re: [bug#74830] [PATCH] gnu: libcbor: Fix cross-compiling to 32-bit architecture
has caused the debbugs.gnu.org bug report #74830,
regarding [PATCH] gnu: libcbor: Fix cross-compiling to 32-bit architecture
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
74830: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74830
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christoph Buck <dev <at> icepic.de>
To: guix-patches <at> gnu.org
Cc: Christoph Buck <dev <at> icepic.de>
Subject: [PATCH] gnu: libcbor: Fix cross-compiling to 32-bit architecture
Date: Thu, 12 Dec 2024 14:04:35 +0000

* gnu/packages/compression.scm (libcbor)[arguments]: Disable examples because
they don't build during cross-compilation. The callback definition
`find_string` in examples/streaming_parser.c uses `size_t` as type for
argument `len` which is 4 bytes on a 32bit platform. However, the callback
handler of type `cbor_callbacks.string` to which `find_string` is assigned
expects an `uint64_t`. Since the examples are not required this patch will
disable them from the build.

Change-Id: I596a62a9d0ab936179c8344e91ecc2cb0419316f
---
 gnu/packages/compression.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm
index 99ea090091..eb3968cbce 100644
--- a/gnu/packages/compression.scm
+++ b/gnu/packages/compression.scm
@@ -2919,6 +2919,7 @@ (define-public libcbor
           "-DCMAKE_BUILD_TYPE=Release"
           "-DBUILD_SHARED_LIBS=ON"
           "-DCBOR_CUSTOM_ALLOC=ON"
+          "-DWITH_EXAMPLES=OFF"
           (string-append "-DCMAKE_INSTALL_LIBDIR=" lib)
           (string-append "-DCMAKE_INSTALL_RPATH=" lib)))))
     (synopsis "The C library for parsing and generating CBOR")

base-commit: d916d3b1568a2def0dfb9089d61f2202db35beb7
-- 
2.46.0

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Christoph Buck <dev <at> icepic.de>
Cc: Simon Tournier <zimon.toutoune <at> gmail.com>, paren <at> disroot.org,
 Tobias Geerinckx-Rice <me <at> tobias.gr>, jgart <jgart <at> dismail.de>,
 Mathieu Othacehe <othacehe <at> gnu.org>, Christopher Baines <guix <at> cbaines.net>,
 74830-done <at> debbugs.gnu.org
Subject: Re: [bug#74830] [PATCH] gnu: libcbor: Fix cross-compiling to 32-bit
 architecture
Date: Sun, 15 Dec 2024 23:54:29 +0100

Christoph Buck <dev <at> icepic.de> skribis:

> * gnu/packages/compression.scm (libcbor)[arguments]: Disable examples because
> they don't build during cross-compilation. The callback definition
> `find_string` in examples/streaming_parser.c uses `size_t` as type for
> argument `len` which is 4 bytes on a 32bit platform. However, the callback
> handler of type `cbor_callbacks.string` to which `find_string` is assigned
> expects an `uint64_t`. Since the examples are not required this patch will
> disable them from the build.
>
> Change-Id: I596a62a9d0ab936179c8344e91ecc2cb0419316f

Applied, thanks.  I took the liberty to add some of the explanation as a
comment, to make it easier to find.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.