GNU bug report logs - #74829
[PATCH] Show the keybinding next to command in calc's x

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74829 in the body.
You can then email your comments to 74829 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Show the keybinding next to command in calc's x
Date: Thu, 12 Dec 2024 18:59:44 +0530

[Message part 1 (text/plain, inline)]

Tags: patch

Attached patch uses M-x's :affixation-function to show the keybinding
next to the command's name in calc's x command.



In GNU Emacs 31.0.50 (build 27, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.18.2, Xaw scroll bars) of 2024-12-07 built on astatine
Repository revision: 9ddec89e422d0dd6e9069731b8f2dd2c90aa5607
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101014
System Description: Debian GNU/Linux trixie/sid

Configured using:
 'configure --with-sound=alsa --with-x-toolkit=lucid --without-xaw3d
 --without-gconf --without-libsystemd --with-cairo CFLAGS=-g3'

[0001-Show-the-keybinding-next-to-command-in-calc-s-x.patch (text/patch, attachment)]

Message #8 received at 74829 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 74829 <at> debbugs.gnu.org
Subject: Re: bug#74829: [PATCH] Show the keybinding next to command in calc's x
Date: Sat, 21 Dec 2024 11:38:41 +0200

> From: Visuwesh <visuweshm <at> gmail.com>
> Date: Thu, 12 Dec 2024 18:59:44 +0530
> 
> Attached patch uses M-x's :affixation-function to show the keybinding
> next to the command's name in calc's x command.

Thanks.  Can you describe the effect of this change in Calc usage?
That is, what will users see after the change that they didn't see
before it?

Message #11 received at 74829 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 74829 <at> debbugs.gnu.org
Subject: Re: bug#74829: [PATCH] Show the keybinding next to command in calc's x
Date: Sat, 21 Dec 2024 15:21:47 +0530

[சனி டிசம்பர் 21, 2024] Eli Zaretskii wrote:

>> From: Visuwesh <visuweshm <at> gmail.com>
>> Date: Thu, 12 Dec 2024 18:59:44 +0530
>> 
>> Attached patch uses M-x's :affixation-function to show the keybinding
>> next to the command's name in calc's x command.
>
> Thanks.  Can you describe the effect of this change in Calc usage?
> That is, what will users see after the change that they didn't see
> before it?

Without the patch, x TAB in the Calc buffer shows in the *Completions*
buffer:

    calc-abs
    calc-abssqr

etc.  But with this patch, it instead shows

    calc-abs (A)
    calc-abssqr (fA)

as calc-abs is bound to the key 'A' (C-h w calc-abs RET confirms this).
This is similar to how M-x displays the keybinding next to the command
name in the *Completions* buffer.

Message #16 received at 74829-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 74829-done <at> debbugs.gnu.org
Subject: Re: bug#74829: [PATCH] Show the keybinding next to command in calc's x
Date: Thu, 26 Dec 2024 10:24:10 +0200

> From: Visuwesh <visuweshm <at> gmail.com>
> Cc: 74829 <at> debbugs.gnu.org
> Date: Sat, 21 Dec 2024 15:21:47 +0530
> 
> [சனி டிசம்பர் 21, 2024] Eli Zaretskii wrote:
> 
> >> From: Visuwesh <visuweshm <at> gmail.com>
> >> Date: Thu, 12 Dec 2024 18:59:44 +0530
> >> 
> >> Attached patch uses M-x's :affixation-function to show the keybinding
> >> next to the command's name in calc's x command.
> >
> > Thanks.  Can you describe the effect of this change in Calc usage?
> > That is, what will users see after the change that they didn't see
> > before it?
> 
> Without the patch, x TAB in the Calc buffer shows in the *Completions*
> buffer:
> 
>     calc-abs
>     calc-abssqr
> 
> etc.  But with this patch, it instead shows
> 
>     calc-abs (A)
>     calc-abssqr (fA)
> 
> as calc-abs is bound to the key 'A' (C-h w calc-abs RET confirms this).
> This is similar to how M-x displays the keybinding next to the command
> name in the *Completions* buffer.

Thanks, installed on the master branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.