GNU bug report logs - #74828
ELPA release note summary strips one line

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74828 in the body.
You can then email your comments to 74828 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: "emacs-bugs" <bug-gnu-emacs <at> gnu.org>
Subject: ELPA release note summary strips one line
Date: Thu, 12 Dec 2024 14:05:42 +0100

Hi all,

ELPA sends a note when a new package version is released.  IIUC, the
"Summary" part in this note is gathered from the ";;; Commentary:"
section of the file where the version is bumped.

I have the impression that one line is left out when the "Summary" is
generated.  See for example:

https://lists.gnu.org/archive/html/auctex-devel/2024-06/msg00036.html
https://lists.gnu.org/archive/html/auctex-devel/2024-10/msg00003.html
https://lists.gnu.org/archive/html/auctex-devel/2024-12/msg00002.html

Best, Arash

Message #8 received at 74828 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Arash Esbati <arash <at> gnu.org>
Cc: Philip Kaludercic <philipk <at> posteo.net>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>, 74828 <at> debbugs.gnu.org
Subject: Re: bug#74828: ELPA release note summary strips one line
Date: Wed, 1 Jan 2025 19:34:41 -0600

Arash Esbati <arash <at> gnu.org> writes:

> Hi all,
>
> ELPA sends a note when a new package version is released.  IIUC, the
> "Summary" part in this note is gathered from the ";;; Commentary:"
> section of the file where the version is bumped.
>
> I have the impression that one line is left out when the "Summary" is
> generated.  See for example:
>
> https://lists.gnu.org/archive/html/auctex-devel/2024-06/msg00036.html
> https://lists.gnu.org/archive/html/auctex-devel/2024-10/msg00003.html
> https://lists.gnu.org/archive/html/auctex-devel/2024-12/msg00002.html
>
> Best, Arash

Philip, Stefan, any comments here?

Message #11 received at 74828 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Arash Esbati <arash <at> gnu.org>, Philip Kaludercic <philipk <at> posteo.net>,
 74828 <at> debbugs.gnu.org
Subject: Re: bug#74828: ELPA release note summary strips one line
Date: Wed, 01 Jan 2025 22:13:35 -0500

>> ELPA sends a note when a new package version is released.  IIUC, the
>> "Summary" part in this note is gathered from the ";;; Commentary:"
>> section of the file where the version is bumped.
>>
>> I have the impression that one line is left out when the "Summary" is
>> generated.  See for example:

Yup, sure enough.
I believe I have fixed it with the patch below.


        Stefan


diff --git a/elpa-admin.el b/elpa-admin.el
index 72ff400c4f..c291c04448 100644
--- a/elpa-admin.el
+++ b/elpa-admin.el
@@ -1,6 +1,6 @@
 ;;; elpa-admin.el --- Auto-generate an Emacs Lisp package archive  -*- lexical-binding:t -*-
 
-;; Copyright (C) 2011-2024  Free Software Foundation, Inc
+;; Copyright (C) 2011-2025  Free Software Foundation, Inc
 
 ;; Author: Stefan Monnier <monnier <at> iro.umontreal.ca>
 
@@ -2652,12 +2652,16 @@ If WITH-CORE is non-nil, it means we manage :core packages as well."
             (insert (if (not readme)
                         "[Not provided 🙁]"
                       (elpaa--section-to-plain-text readme)))
+            ;; It's import to terminate lines properly so we can detect
+            ;; truncated lines below to throw away the leftovers.
+            (unless (bolp) (insert "\n"))
             ;; Keep a max of about 10 lines of full-length text.
             (delete-region (min (+ beg 800) (point)) (point))
             (let ((end (point)))
               (delete-region
                ;; Truncate at the end of the nearest paragraph.
                (or (re-search-backward "\n[ \t]*$" beg t)
+                   ;; Throw away leftovers from truncated lines.
                    (re-search-backward "\n" beg t)
                    (point))
                end))

Message #16 received at 74828-done <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Philip Kaludercic <philipk <at> posteo.net>,
 Stefan Kangas <stefankangas <at> gmail.com>, 74828-done <at> debbugs.gnu.org
Subject: Re: bug#74828: ELPA release note summary strips one line
Date: Thu, 02 Jan 2025 18:02:34 +0100

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>>> ELPA sends a note when a new package version is released.  IIUC, the
>>> "Summary" part in this note is gathered from the ";;; Commentary:"
>>> section of the file where the version is bumped.
>>>
>>> I have the impression that one line is left out when the "Summary" is
>>> generated.  See for example:
>
> Yup, sure enough.
> I believe I have fixed it with the patch below.

Thanks for the change.  I trust your patch works, so I'm closing this
report.  I will have an eye on this with next AUCTeX release; I will
re-open the report if necessary.

Best, Arash

Message #19 received at 74828-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Arash Esbati <arash <at> gnu.org>
Cc: Philip Kaludercic <philipk <at> posteo.net>,
 Stefan Kangas <stefankangas <at> gmail.com>, 74828-done <at> debbugs.gnu.org
Subject: Re: bug#74828: ELPA release note summary strips one line
Date: Thu, 02 Jan 2025 12:20:41 -0500

Hi Arash, and happy new year,

> Thanks for the change.  I trust your patch works, so I'm closing this
> report.  I will have an eye on this with next AUCTeX release; I will
> re-open the report if necessary.

And thanks for noticing the problem.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.