GNU bug report logs - #74821
[PATCH] gnu: cgit: Update to 1.2.3-7.751a5b5.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74821 in the body.
You can then email your comments to 74821 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tomas Volf <~@wolfsden.cz>
To: guix-patches <at> gnu.org
Cc: Tomas Volf <~@wolfsden.cz>
Subject: [PATCH] gnu: cgit: Update to 1.2.3-7.751a5b5.
Date: Thu, 12 Dec 2024 12:46:35 +0100

* gnu/packages/version-control.scm (cgit): Update to 1.2.3-7.751a5b5.

Change-Id: I3f4d27246065d67a258a8cf3b3dea2e0b2d2bc9f
---
 gnu/packages/version-control.scm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 3339e79390..28afcfa2ff 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -1345,8 +1345,8 @@ (define-public git-remote-gcrypt
    (license license:gpl3+)))
 
 (define-public cgit
-  (let ((commit "2a13177f3dce660954b1ce78bc83338fe64f6b33")
-        (rev "6"))
+  (let ((commit "751a5b527de07dde30a69709c2d6fc6f05fafd06")
+        (rev "7"))
     (package
       (name "cgit")
       ;; Update the ‘git-source’ input as well.
@@ -1358,7 +1358,7 @@ (define-public cgit
                       (commit commit)))
                 (sha256
                  (base32
-                  "0g02rghwx6gda15ip1pd3rli6smis1mrcb904zlxfqmm6dlc7lca"))
+                  "0rfflh7fnfhchd7pdspn2r416c5kaya37cad918f7ldidzwvmp37"))
                 (file-name (git-file-name name version))))
       (build-system gnu-build-system)
       (arguments
@@ -1434,9 +1434,9 @@ (define-public cgit
              (method url-fetch)
              ;; cgit is tightly bound to git.  Use GIT_VER from the Makefile,
              ;; which may not match the current (package-version git).
-             (uri "mirror://kernel.org/software/scm/git/git-2.46.2.tar.xz")
+             (uri "mirror://kernel.org/software/scm/git/git-2.47.1.tar.xz")
              (sha256
-              (base32 "18rcmvximgyg3v1a9papi9djfamiak0ys5cmgx7ll29nhp3a3s2y"))))
+              (base32 "046kdr5dhg31hjcg6wpfqnwwbaqdjyax7n8wx5s26fdf4fxzkn7k"))))
          ("bash-minimal" ,bash-minimal)
          ("openssl" ,openssl)
          ("python" ,python)
-- 
2.46.0

Message #8 received at 74821 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Tomas Volf <~@wolfsden.cz>
Cc: 74821 <at> debbugs.gnu.org
Subject: Re: [bug#74821] [PATCH] gnu: cgit: Update to 1.2.3-7.751a5b5.
Date: Tue, 17 Dec 2024 10:24:42 +0900

Hi Tomas,

Tomas Volf <~@wolfsden.cz> writes:

> * gnu/packages/version-control.scm (cgit): Update to 1.2.3-7.751a5b5.
>
> Change-Id: I3f4d27246065d67a258a8cf3b3dea2e0b2d2bc9f
> ---
>  gnu/packages/version-control.scm | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
> index 3339e79390..28afcfa2ff 100644
> --- a/gnu/packages/version-control.scm
> +++ b/gnu/packages/version-control.scm
> @@ -1345,8 +1345,8 @@ (define-public git-remote-gcrypt
>     (license license:gpl3+)))
>

Usually, we request that a comment is added to explain why a particular
unreleased commit must be used instead of the latest release.  Would it
be possible to remove the commit/rev variables and switch back to use
the latest release?  It's not clear why we aren't doing that.

-- 
Thanks,
Maxim

Message #11 received at 74821 <at> debbugs.gnu.org (full text, mbox):

From: Tomas Volf <~@wolfsden.cz>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 74821 <at> debbugs.gnu.org
Subject: Re: [bug#74821] [PATCH] gnu: cgit: Update to 1.2.3-7.751a5b5.
Date: Wed, 18 Dec 2024 15:26:44 +0100

[Message part 1 (text/plain, inline)]

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> Hi Tomas,
>
> Tomas Volf <~@wolfsden.cz> writes:
>
>> * gnu/packages/version-control.scm (cgit): Update to 1.2.3-7.751a5b5.
>>
>> Change-Id: I3f4d27246065d67a258a8cf3b3dea2e0b2d2bc9f
>> ---
>>  gnu/packages/version-control.scm | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
>> index 3339e79390..28afcfa2ff 100644
>> --- a/gnu/packages/version-control.scm
>> +++ b/gnu/packages/version-control.scm
>> @@ -1345,8 +1345,8 @@ (define-public git-remote-gcrypt
>>     (license license:gpl3+)))
>>
>
> Usually, we request that a comment is added to explain why a particular
> unreleased commit must be used instead of the latest release.

This was not requested 11 months back when I did the initial upgrade,
but fair enough.  Shall I send a separate patch adding the comment?

> Would it be possible to remove the commit/rev variables and switch
> back to use the latest release?  It's not clear why we aren't doing
> that.

Possible?  Sure.  Good idea?  Not in my opinion.  Last release is from 5
years ago, and there were many bug fixes since then.  Even sites like
git.kernel.org do not use the last release.

Have a nice day,
Tomas Volf

-- 
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 74821-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Tomas Volf <~@wolfsden.cz>
Cc: 74821-done <at> debbugs.gnu.org
Subject: Re: [bug#74821] [PATCH] gnu: cgit: Update to 1.2.3-7.751a5b5.
Date: Thu, 19 Dec 2024 14:41:30 +0900

Hi Tomas,

I've added a comment mentioning why we use the latest commit (no tagged
releases in 5 years) and pushed.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.