GNU bug report logs - #74820
[PATCH] browse-url-with-browser-kind: Improve browser function selection

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74820 in the body.
You can then email your comments to 74820 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] browse-url-with-browser-kind: Improve browser function
 selection
Date: Thu, 12 Dec 2024 12:41:50 +0100

[Message part 1 (text/plain, inline)]

Tags: patch

In order to find an appropriate browser function for the given
kind, first the browser handler lists are consulted.  If no
handler is found, the `browse-url-browser-function',
`browse-url-secondary-browser-function`,
`browse-url-default-browser' and `eww' are tried in that order
until a browser function with a matching kind is found.  This
way the user customization of `browse-url-browser-function' and
`browse-url-secondary-browser-function` is respected by
`browse-url-with-browser-kind'.

[0001-browse-url-with-browser-kind-Improve-browser-functio.patch (text/patch, attachment)]

Message #8 received at 74820 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: 74820 <at> debbugs.gnu.org
Cc: Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#74820: [PATCH] browse-url-with-browser-kind: Improve
 browser function selection
Date: Tue, 17 Dec 2024 12:16:54 +0100

Daniel Mendler <mail <at> daniel-mendler.de> writes:

> Tags: patch
>
> In order to find an appropriate browser function for the given
> kind, first the browser handler lists are consulted.  If no
> handler is found, the `browse-url-browser-function',
> `browse-url-secondary-browser-function`,
> `browse-url-default-browser' and `eww' are tried in that order
> until a browser function with a matching kind is found.  This
> way the user customization of `browse-url-browser-function' and
> `browse-url-secondary-browser-function` is respected by
> `browse-url-with-browser-kind'.

Eli, do you have comments on this patch? I think it improves the
behavior of `browse-url-with-browser-kind' in relation to our recent
changes to `browse-url-browser-function' and `browse-url-secondary-browser-function',
which users can set to either internal or external browsers. Thanks.

Daniel

Message #11 received at 74820 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: 74820 <at> debbugs.gnu.org
Subject: Re: bug#74820: [PATCH] browse-url-with-browser-kind: Improve
 browser function selection
Date: Tue, 17 Dec 2024 15:49:38 +0200

> From: Daniel Mendler <mail <at> daniel-mendler.de>
> Cc: Eli Zaretskii <eliz <at> gnu.org>
> Date: Tue, 17 Dec 2024 12:16:54 +0100
> 
> Daniel Mendler <mail <at> daniel-mendler.de> writes:
> 
> > Tags: patch
> >
> > In order to find an appropriate browser function for the given
> > kind, first the browser handler lists are consulted.  If no
> > handler is found, the `browse-url-browser-function',
> > `browse-url-secondary-browser-function`,
> > `browse-url-default-browser' and `eww' are tried in that order
> > until a browser function with a matching kind is found.  This
> > way the user customization of `browse-url-browser-function' and
> > `browse-url-secondary-browser-function` is respected by
> > `browse-url-with-browser-kind'.
> 
> Eli, do you have comments on this patch? I think it improves the
> behavior of `browse-url-with-browser-kind' in relation to our recent
> changes to `browse-url-browser-function' and `browse-url-secondary-browser-function',
> which users can set to either internal or external browsers. Thanks.

I didn't yet have time to review the patch.  Too little free time,
sorry.  Will do soon.

Message #14 received at 74820 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 74820 <at> debbugs.gnu.org
Subject: Re: bug#74820: [PATCH] browse-url-with-browser-kind: Improve
 browser function selection
Date: Tue, 17 Dec 2024 14:57:40 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Daniel Mendler <mail <at> daniel-mendler.de>
>> Cc: Eli Zaretskii <eliz <at> gnu.org>
>> Date: Tue, 17 Dec 2024 12:16:54 +0100
>> 
>> Daniel Mendler <mail <at> daniel-mendler.de> writes:
>> 
>> > Tags: patch
>> >
>> > In order to find an appropriate browser function for the given
>> > kind, first the browser handler lists are consulted.  If no
>> > handler is found, the `browse-url-browser-function',
>> > `browse-url-secondary-browser-function`,
>> > `browse-url-default-browser' and `eww' are tried in that order
>> > until a browser function with a matching kind is found.  This
>> > way the user customization of `browse-url-browser-function' and
>> > `browse-url-secondary-browser-function` is respected by
>> > `browse-url-with-browser-kind'.
>> 
>> Eli, do you have comments on this patch? I think it improves the
>> behavior of `browse-url-with-browser-kind' in relation to our recent
>> changes to `browse-url-browser-function' and `browse-url-secondary-browser-function',
>> which users can set to either internal or external browsers. Thanks.
>
> I didn't yet have time to review the patch.  Too little free time,
> sorry.  Will do soon.

Thanks. Take your time. There is no urgency regarding this patch.

Daniel

Message #19 received at 74820-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: 74820-done <at> debbugs.gnu.org
Subject: Re: bug#74820: [PATCH] browse-url-with-browser-kind: Improve browser
 function selection
Date: Sat, 21 Dec 2024 11:34:45 +0200

> Date: Thu, 12 Dec 2024 12:41:50 +0100
> From:  Daniel Mendler via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> In order to find an appropriate browser function for the given
> kind, first the browser handler lists are consulted.  If no
> handler is found, the `browse-url-browser-function',
> `browse-url-secondary-browser-function`,
> `browse-url-default-browser' and `eww' are tried in that order
> until a browser function with a matching kind is found.  This
> way the user customization of `browse-url-browser-function' and
> `browse-url-secondary-browser-function` is respected by
> `browse-url-with-browser-kind'.

Thanks, I've now installed this on the master branch, and I'm
therefore closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.