GNU bug report logs - #74803
31.0.50; [PATCH] Fix bug that semantic did not restore imenu-create-index-function on exiting

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#74803: closed (31.0.50; [PATCH] Fix bug that semantic did not
 restore imenu-create-index-function on exiting)
Date: Sat, 14 Dec 2024 10:41:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 14 Dec 2024 12:40:35 +0200
with message-id <86jzc2v97g.fsf <at> gnu.org>
and subject line Re: bug#74803: 31.0.50; [PATCH] Fix bug that semantic did not restore imenu-create-index-function on exiting
has caused the debbugs.gnu.org bug report #74803,
regarding 31.0.50; [PATCH] Fix bug that semantic did not restore imenu-create-index-function on exiting
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
74803: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74803
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Lin Sun <sunlin7 <at> hotmail.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 31.0.50; [PATCH] Fix bug that semantic did not restore
 imenu-create-index-function on exiting
Date: Wed, 11 Dec 2024 22:30:02 +0000

[Message part 3 (text/plain, inline)]

The semantic minor mode changed the value of imenu-create-index-function on its startup, but does not restore the original value on its exiting. 

Here are the steps to reproduce the issue:

1. Start the emacs and open a python script, now the imenu-create-index-function will be the `python-imenu-create-index'

 $ emacs -nw -q ~/a.py   

2. Turn-on the semantic by "M-x semantic-mode", then the  imenu-create-index-function will be the `semantic-create-imenu-index'

3. Turn-off the semantic by "M-x semantic-mode",  imenu-create-index-function is still the semantic one.

This patch will store the original imenu-create-index-function before changing it, and restore the original value when turn-off the semantic-mode. 

[0001-Fix-bug-that-semantic-did-not-restore-imenu-create-i.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lin Sun <sunlin7 <at> hotmail.com>
Cc: 74803-done <at> debbugs.gnu.org
Subject: Re: bug#74803: 31.0.50; [PATCH] Fix bug that semantic did not restore
 imenu-create-index-function on exiting
Date: Sat, 14 Dec 2024 12:40:35 +0200

> From: Lin Sun <sunlin7 <at> hotmail.com>
> Date: Wed, 11 Dec 2024 22:30:02 +0000
> 
> The semantic minor mode changed the value of imenu-create-index-function on its startup, but does not restore the original value on its exiting. 
> 
> Here are the steps to reproduce the issue:
> 
> 1. Start the emacs and open a python script, now the imenu-create-index-function will be the `python-imenu-create-index'
> 
>  $ emacs -nw -q ~/a.py   
> 
> 2. Turn-on the semantic by "M-x semantic-mode", then the  imenu-create-index-function will be the `semantic-create-imenu-index'
> 
> 3. Turn-off the semantic by "M-x semantic-mode",  imenu-create-index-function is still the semantic one.
> 
> This patch will store the original imenu-create-index-function before changing it, and restore the original value when turn-off the semantic-mode. 

Thanks, installed on the master branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.