GNU bug report logs - #74803
31.0.50; [PATCH] Fix bug that semantic did not restore imenu-create-index-function on exiting

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74803 in the body.
You can then email your comments to 74803 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lin Sun <sunlin7 <at> hotmail.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 31.0.50; [PATCH] Fix bug that semantic did not restore
 imenu-create-index-function on exiting
Date: Wed, 11 Dec 2024 22:30:02 +0000

[Message part 1 (text/plain, inline)]

The semantic minor mode changed the value of imenu-create-index-function on its startup, but does not restore the original value on its exiting. 

Here are the steps to reproduce the issue:

1. Start the emacs and open a python script, now the imenu-create-index-function will be the `python-imenu-create-index'

 $ emacs -nw -q ~/a.py   

2. Turn-on the semantic by "M-x semantic-mode", then the  imenu-create-index-function will be the `semantic-create-imenu-index'

3. Turn-off the semantic by "M-x semantic-mode",  imenu-create-index-function is still the semantic one.

This patch will store the original imenu-create-index-function before changing it, and restore the original value when turn-off the semantic-mode. 

[0001-Fix-bug-that-semantic-did-not-restore-imenu-create-i.patch (text/x-patch, attachment)]

Message #10 received at 74803-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lin Sun <sunlin7 <at> hotmail.com>
Cc: 74803-done <at> debbugs.gnu.org
Subject: Re: bug#74803: 31.0.50; [PATCH] Fix bug that semantic did not restore
 imenu-create-index-function on exiting
Date: Sat, 14 Dec 2024 12:40:35 +0200

> From: Lin Sun <sunlin7 <at> hotmail.com>
> Date: Wed, 11 Dec 2024 22:30:02 +0000
> 
> The semantic minor mode changed the value of imenu-create-index-function on its startup, but does not restore the original value on its exiting. 
> 
> Here are the steps to reproduce the issue:
> 
> 1. Start the emacs and open a python script, now the imenu-create-index-function will be the `python-imenu-create-index'
> 
>  $ emacs -nw -q ~/a.py   
> 
> 2. Turn-on the semantic by "M-x semantic-mode", then the  imenu-create-index-function will be the `semantic-create-imenu-index'
> 
> 3. Turn-off the semantic by "M-x semantic-mode",  imenu-create-index-function is still the semantic one.
> 
> This patch will store the original imenu-create-index-function before changing it, and restore the original value when turn-off the semantic-mode. 

Thanks, installed on the master branch, and closing the bug.

Message #13 received at 74803-done <at> debbugs.gnu.org (full text, mbox):

From: Lin Sun <sunlin7 <at> hotmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: "74803-done <at> debbugs.gnu.org" <74803-done <at> debbugs.gnu.org>
Subject: Re: bug#74803: 31.0.50; [PATCH] Fix bug that semantic did not restore
 imenu-create-index-function on exiting
Date: Sat, 14 Dec 2024 17:01:08 +0000

> From: Eli Zaretskii <eliz <at> gnu.org>
> Sent: Saturday, December 14, 2024 02:40 AM
>
> Thanks, installed on the master branch, and closing the bug.

Thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.