GNU bug report logs - #74786
[PATCH] Add custom args to test compile step

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: "O'Brien, Will" <will.08rien <at> gmail.com>
Subject: bug#74786: closed (Re: bug#74786: [PATCH] Add custom args to test
 compile step)
Date: Sun, 05 Jan 2025 12:44:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#74786: [PATCH] Add custom args to test compile step

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 74786 <at> debbugs.gnu.org.

-- 
74786: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74786
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Randy Taylor <dev <at> rjt.dev>
Cc: will.08rien <at> gmail.com, 74786-done <at> debbugs.gnu.org, rpluim <at> gmail.com,
 jp <at> neverwas.me
Subject: Re: bug#74786: [PATCH] Add custom args to test compile step
Date: Sun, 05 Jan 2025 14:43:07 +0200

> Date: Sat, 04 Jan 2025 19:05:55 +0000
> From: Randy Taylor <dev <at> rjt.dev>
> Cc: "J.P." <jp <at> neverwas.me>, Robert Pluim <rpluim <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>, 74786 <at> debbugs.gnu.org
> 
> Thanks, looks good to me.
> 
> Eli, please install if you have no further comments. Thanks in
> advance.

Thanks, installed on the master branch, and closing the bug.

[Message part 3 (message/rfc822, inline)]

From: "O'Brien, Will" <will.08rien <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add custom args to test compile step
Date: Wed, 11 Dec 2024 10:18:04 +0000

[Message part 4 (text/plain, inline)]

Tags: patch

Hi,

First time trying to contribute here, so apologies for any wrong doing.  I
haven't signed FSF papers; would be happy to but believe this may fit in to
tiny patch territory.

This is a feature request to pass custom flags down to the test compile
step in go-ts-mode-test-... functions.  Specifically I wanted to
add the coverprofile argument to unit test invocation.

The attached patch seems to do the trick for me.


In GNU Emacs 31.0.50 (build 1, aarch64-apple-darwin23.6.0, NS
 appkit-2487.70 Version 14.6.1 (Build 23G93)) of 2024-09-02 built
 on Wills-MacBook-Pro.local
Windowing system distributor 'Apple', version 10.3.2575
System Description:  macOS 15.1.1

Configured using:
 'configure --disable-silent-rules
 --prefix=/nix/store/2hqk7brndnbi3r5c2rjyhx0k19m1q77j-w08r-emacs-92ea393a16e
 --enable-locallisppath=/nix/store/2hqk7brndnbi3r5c2rjyhx0k19m1q77j-w08r-emacs-92ea393a16e/site-lisp
 --without-dbus --without-imagemagick --with-mailutils
 --disable-ns-self-contained --with-cairo --with-modules
 --with-xml2 --with-gnutls --with-rsvg --with-native-compilation
 --with-gnutls=ifavailable
 --enable-mac-app=/nix/store/2hqk7brndnbi3r5c2rjyhx0k19m1q77j-w08r-emacs-92ea393a16e/Applications
 --with-xwidgets --with-tree-sitter 'CFLAGS=-O3 -isysroot
 /Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk/
 -framework AppKit'
 'CPPFLAGS=-I/Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk/usr/include
 -isysroot
 /Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk/
 -I/Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk//System/Library/Frameworks/AppKit.framework/Versions/C/Headers
 -I/nix/store/d3f47kd7kr5xdpcgs3xx7bg2mx5fbb0z-libgccjit-12.2.0/include'
 'LDFLAGS=-O3 -L
 /nix/store/d3f47kd7kr5xdpcgs3xx7bg2mx5fbb0z-libgccjit-12.2.0/lib''


best
--
will

[0001-Add-custom-args-to-test-compile-step.patch (text/patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.