GNU bug report logs - #74787
guile-ssh@0.18 breaks offloading

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74787 in the body.
You can then email your comments to 74787 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dariqq <dariqq <at> posteo.net>
To: bug-guix <at> gnu.org
Subject: guile-ssh <at> 0.18 breaks offloading
Date: Wed, 11 Dec 2024 12:55:10 +0000

Hello,

Today I reconfigured my system and after a reboot offloading no longer 
works.

When i try to build something that could be offloaded it instead tries 
to build it locally instead and fails with

unsupported-platform
while setting up the build environment: a `*' is required to build `*', 
but I am a `*'

However 'guix offload test' is still succeeding

--8<---------------cut here---------------start------------->8---
sudo guix offload test

guix offload: testing 1 build machines defined in 
'/etc/guix/machines.scm'...
guix offload: Guix is usable on '*' (test returned "/gnu/store/*-test")
guix offload: '*' is running GNU Guile 3.0.9
guix offload: sending 1 store item (0 MiB) to '*'...
exporting path `/gnu/store/*-export-test'
guix offload: '*' successfully imported '/gnu/store/*-export-test'
retrieving 1 store item from '*'...
guix offload: successfully imported '/gnu/store/*-import-test' from '*'

--8<---------------cut here---------------end--------------->8---


I tracked this down to the guile-ssh update in 
da3c8a963f83c044568d99921480259eaa26a923

Reverting that restores offloading for me.


This might also be the cause for the 'guix deploy' error described in 
https://logs.guix.gnu.org/guix/2024-12-11.log#033439

Message #8 received at 74787 <at> debbugs.gnu.org (full text, mbox):

From: Tomas Volf <~@wolfsden.cz>
To: 74787 <at> debbugs.gnu.org,
	guix-patches <at> gnu.org
Cc: Tomas Volf <~@wolfsden.cz>
Subject: [PATCH] remote: Do not double-quote the repl-command.
Date: Wed, 11 Dec 2024 17:27:55 +0100

In 0.18.0, the `open-remote-pipe*' now correctly quotes the arguments, so the
double quoting that was done by `shell-quote' is not harmful and breaks at
least offloading and deploy.

* guix/remote.scm (remote-pipe-for-gexp): Call object->string just once.

Change-Id: Id922d26d318bfdd4714e267687c1b27461196d90
---
I checked all places where the changed procedures are used and those look
correct.  Nothing else in the NEWS file for 0.18.0 jumps out as a potential
issue.

 guix/remote.scm | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/guix/remote.scm b/guix/remote.scm
index a58ec2103c..9423f9af12 100644
--- a/guix/remote.scm
+++ b/guix/remote.scm
@@ -48,9 +48,6 @@ (define-module (guix remote)
 (define* (remote-pipe-for-gexp lowered session #:optional become-command)
   "Return a remote pipe for the given SESSION to evaluate LOWERED.  If
 BECOME-COMMAND is given, use that to invoke the remote Guile REPL."
-  (define shell-quote
-    (compose object->string object->string))
-
   (define repl-command
     (append (or become-command '())
             (list
@@ -65,7 +62,7 @@ (define* (remote-pipe-for-gexp lowered session #:optional become-command)
                           `("-C" ,directory))
                         (lowered-gexp-load-path lowered))
             `("-c"
-              ,(shell-quote (lowered-gexp-sexp lowered)))))
+              ,(object->string (lowered-gexp-sexp lowered)))))

   (let ((pipe (apply open-remote-pipe* session OPEN_READ repl-command)))
     (when (eof-object? (peek-char pipe))
--
2.46.0

Message #11 received at 74787 <at> debbugs.gnu.org (full text, mbox):

From: Dariqq <dariqq <at> posteo.net>
To: 74787 <at> debbugs.gnu.org
Subject: Re: guile-ssh <at> 0.18 breaks offloading
Date: Wed, 11 Dec 2024 20:57:46 +0000

Another problem (other than the open-input-pipe* change) related to the 
guile-ssh update is that the GUIX_CHECK_GUILE_SSH macro now fails 
resulting in the guix-daemon not having offload support. I openend 
https://issues.guix.gnu.org/74800 for this

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tomas Volf <~@wolfsden.cz>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>,
 Simon Tournier <zimon.toutoune <at> gmail.com>, Mathieu Othacehe <othacehe <at> gnu.org>,
 Tobias Geerinckx-Rice <me <at> tobias.gr>, Dariqq <dariqq <at> posteo.net>,
 Christopher Baines <guix <at> cbaines.net>, 74787-done <at> debbugs.gnu.org,
 guix-patches <at> gnu.org
Subject: Re: bug#74787: guile-ssh <at> 0.18 breaks offloading
Date: Thu, 12 Dec 2024 12:45:56 +0100

Hi Tomas and Dariqq,

Tomas Volf <~@wolfsden.cz> skribis:

> In 0.18.0, the `open-remote-pipe*' now correctly quotes the arguments, so the
> double quoting that was done by `shell-quote' is not harmful and breaks at
> least offloading and deploy.
>
> * guix/remote.scm (remote-pipe-for-gexp): Call object->string just once.
>
> Change-Id: Id922d26d318bfdd4714e267687c1b27461196d90

Added the “Fixes” and “Reported-by” lines to the log and committed.

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.