GNU bug report logs - #74786
[PATCH] Add custom args to test compile step

Previous Next

Full log

Message #46 received at 74786 <at> debbugs.gnu.org (full text, mbox):

From: "O'Brien, Will" <will.08rien <at> gmail.com>
To: Randy Taylor <dev <at> rjt.dev>
Cc: Robert Pluim <rpluim <at> gmail.com>, 74786 <at> debbugs.gnu.org,
 Eli Zaretskii <eliz <at> gnu.org>, "J.P." <jp <at> neverwas.me>
Subject: Re: bug#74786: [PATCH] Add custom args to test compile step
Date: Thu, 02 Jan 2025 11:21:54 +0000

[Message part 1 (text/plain, inline)]

On Wed, Jan 01 2025 at 23:50, Randy Taylor <dev <at> rjt.dev> wrote:

> Thanks, the patch looks good to me.
> There is a typo:
> +  "Return the flags for test invoation."
>                               ^invocation
>

Fixed.

[...]

>> I think that we can remove the `-run` flag from this function.
>> What do others think? Also, should this be a separate bug/patch
>> (if indeed it is a bug) or I can incorporate this change into the
>> current change set.
>> 
>
> I believe you are correct, we can get rid of the -run flag.
> Please incorporate these changes as part of this patch.

Done.

> (Side note, maybe we should actually pass the package to
> go test instead of relying on default directory but
> don't worry about that for this patch).

Will raise a new issue.

best
--
will

[0001-Enable-extra-flags-in-go-ts-mode-test-commands.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.