GNU bug report logs - #74786
[PATCH] Add custom args to test compile step

Previous Next

Full log

Message #35 received at 74786 <at> debbugs.gnu.org (full text, mbox):

From: "O'Brien, Will" <will.08rien <at> gmail.com>
To: Randy Taylor <dev <at> rjt.dev>, "J.P." <jp <at> neverwas.me>
Cc: Robert Pluim <rpluim <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>,
 74786 <at> debbugs.gnu.org
Subject: Re: bug#74786: [PATCH] Add custom args to test compile step
Date: Thu, 19 Dec 2024 16:20:18 +0000

[Message part 1 (text/plain, inline)]

Hi,

On Tue, Dec 17 2024 at 08:34, "O'Brien, Will" <will.08rien <at> gmail.com> wrote:

> On Sun, Dec 15 2024 at 02:17, Randy Taylor <dev <at> rjt.dev> wrote:
>
>> On Wednesday, December 11th, 2024 at 11:31, O'Brien, Will <will.08rien <at> gmail.com> wrote:

[...]


>> +  (compile (format "go test %s -v %s -run '%s'"
>> +                   (string-join go-ts-mode-test-args)
>> With the above in mind, we may want to move the %s to the absolute
>> end so that -args could be used without catastrophe.
>
> Got it.  Right I'll work on this and test out a few options with
> combinations flags.
>
>> This will also need a commit message and a NEWS entry.
>> See the CONTRIBUTE file for details.
>
> Ok, will send new patch with code changes and NEW entry along with
> a commit message.

I believe the attached patch should cover your suggestion, Randy,
as well as incorporating Robert's and J.P.'s suggestions.

I have tried to update NEWS and used a commit message within the
patch which I believe conforms to the requirements laid out in
CONTRIBUTE.

Look forward to hearing your feedback, thank you all for showing
such patience.

[0001-Enable-extra-flags-in-go-ts-mode-test-commands.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.