GNU bug report logs - #74786
[PATCH] Add custom args to test compile step

Previous Next

Full log

Message #23 received at 74786 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: "O'Brien, Will" <will.08rien <at> gmail.com>
Cc: Robert Pluim <rpluim <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>,
 74786 <at> debbugs.gnu.org
Subject: Re: bug#74786: [PATCH] Add custom args to test compile step
Date: Sun, 15 Dec 2024 02:17:55 +0000

On Wednesday, December 11th, 2024 at 11:31, O'Brien, Will <will.08rien <at> gmail.com> wrote:
> [...]
> 
> Ah, thanks! I've attached a new patch with the simplification.
> 
> best
> --
> will

Thanks for working on this.

+(defcustom go-ts-mode-test-args nil
+  "List of extra args for the Go test commands."
Should we call this `go-ts-mode-test-flags' instead?
That seems to be the parlance golang uses, and there is an official
`-args' that go test supports that has a specific behaviour:
	-args
	    Pass the remainder of the command line (everything after -args)
	    to the test binary, uninterpreted and unchanged.
	    Because this flag consumes the remainder of the command line,
	    the package list (if present) must appear before this flag.

+  (compile (format "go test %s -v %s -run '%s'"
+                   (string-join go-ts-mode-test-args)
With the above in mind, we may want to move the %s to the absolute
end so that -args could be used without catastrophe.

This will also need a commit message and a NEWS entry.
See the CONTRIBUTE file for details.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.