GNU bug report logs - #7473
24.0.50; `diff' command broken

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#7473: closed (24.0.50; `diff' command broken)
Date: Thu, 25 Nov 2010 04:51:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 24 Nov 2010 23:45:42 -0500
with message-id <jwvpqtu2erh.fsf-monnier+emacs <at> gnu.org>
and subject line Re: bug#7473: 24.0.50; `diff' command broken
has caused the GNU bug report #7473,
regarding 24.0.50; `diff' command broken
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
7473: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7473
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Dani Moncayo <dmoncayo <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; `diff' command broken
Date: Wed, 24 Nov 2010 19:51:41 +0100

Hello,

0) Start emacs (emacs -Q)
1) M-x diff <RET>

After that, the minibuffer shows the error message: `Symbol's value as
variable is void: newf'.


In GNU Emacs 24.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.22.0)
 of 2010-11-24 on dani-P5PL2
Windowing system distributor `The X.Org Foundation', version 11.0.10900000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: es_ES.utf8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t


-- 
Dani Moncayo

[Message part 3 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Dani Moncayo <dmoncayo <at> gmail.com>
Subject: Re: bug#7473: 24.0.50; `diff' command broken
Date: Wed, 24 Nov 2010 23:45:42 -0500

>> 1) M-x diff <RET>
>> 
>> After that, the minibuffer shows the error message: `Symbol's value as
>> variable is void: newf'.

> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7277#13

Thanks, indeed, should be fixed now,


        Stefan


=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog	2010-11-24 16:39:51 +0000
+++ lisp/ChangeLog	2010-11-25 04:43:30 +0000
@@ -1,3 +1,7 @@
+2010-11-25  Stefan Monnier  <monnier <at> iro.umontreal.ca>
+
+	* vc/diff.el (diff): Fix last change.
+
 2010-11-24  Stefan Monnier  <monnier <at> iro.umontreal.ca>
 
 	* emacs-lisp/pcase.el: Improve pcase-let.  Use "pcase--" prefix.

=== modified file 'lisp/vc/diff.el'
--- lisp/vc/diff.el	2010-11-22 19:22:03 +0000
+++ lisp/vc/diff.el	2010-11-25 04:28:25 +0000
@@ -84,7 +84,7 @@
 interactively for diff switches.  Otherwise, the switches
 specified in `diff-switches' are passed to the diff command."
   (interactive
-   (let ((newf (buffer-file-name))
+   (let* ((newf (buffer-file-name))
          (oldf (file-newest-backup newf)))
      (setq newf (if (and newf (file-exists-p newf))
 		    (read-file-name

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.