GNU bug report logs - #7473
24.0.50; `diff' command broken

Previous Next

Package: emacs;

Reported by: Dani Moncayo <dmoncayo <at> gmail.com>

Date: Wed, 24 Nov 2010 18:47:02 UTC

Severity: normal

Found in version 24.0.50

Done: Stefan Monnier <monnier <at> IRO.UMontreal.CA>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 7473 in the body.
You can then email your comments to 7473 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#7473; Package emacs. (Wed, 24 Nov 2010 18:47:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Dani Moncayo <dmoncayo <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 24 Nov 2010 18:47:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dani Moncayo <dmoncayo <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; `diff' command broken
Date: Wed, 24 Nov 2010 19:51:41 +0100
Hello,

0) Start emacs (emacs -Q)
1) M-x diff <RET>

After that, the minibuffer shows the error message: `Symbol's value as
variable is void: newf'.


In GNU Emacs 24.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.22.0)
 of 2010-11-24 on dani-P5PL2
Windowing system distributor `The X.Org Foundation', version 11.0.10900000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: es_ES.utf8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t


-- 
Dani Moncayo




Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#7473; Package emacs. (Wed, 24 Nov 2010 19:25:02 GMT) Full text and rfc822 format available.

Message #8 received at 7473 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Dani Moncayo <dmoncayo <at> gmail.com>
Cc: 7473 <at> debbugs.gnu.org
Subject: Re: bug#7473: 24.0.50; `diff' command broken
Date: Wed, 24 Nov 2010 14:29:39 -0500
Dani Moncayo wrote:

> 1) M-x diff <RET>
>
> After that, the minibuffer shows the error message: `Symbol's value as
> variable is void: newf'.

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7277#13




Reply sent to Stefan Monnier <monnier <at> IRO.UMontreal.CA>:
You have taken responsibility. (Thu, 25 Nov 2010 04:51:02 GMT) Full text and rfc822 format available.

Notification sent to Dani Moncayo <dmoncayo <at> gmail.com>:
bug acknowledged by developer. (Thu, 25 Nov 2010 04:51:02 GMT) Full text and rfc822 format available.

Message #13 received at 7473-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Dani Moncayo <dmoncayo <at> gmail.com>
Subject: Re: bug#7473: 24.0.50; `diff' command broken
Date: Wed, 24 Nov 2010 23:45:42 -0500
>> 1) M-x diff <RET>
>> 
>> After that, the minibuffer shows the error message: `Symbol's value as
>> variable is void: newf'.

> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7277#13

Thanks, indeed, should be fixed now,


        Stefan


=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog	2010-11-24 16:39:51 +0000
+++ lisp/ChangeLog	2010-11-25 04:43:30 +0000
@@ -1,3 +1,7 @@
+2010-11-25  Stefan Monnier  <monnier <at> iro.umontreal.ca>
+
+	* vc/diff.el (diff): Fix last change.
+
 2010-11-24  Stefan Monnier  <monnier <at> iro.umontreal.ca>
 
 	* emacs-lisp/pcase.el: Improve pcase-let.  Use "pcase--" prefix.

=== modified file 'lisp/vc/diff.el'
--- lisp/vc/diff.el	2010-11-22 19:22:03 +0000
+++ lisp/vc/diff.el	2010-11-25 04:28:25 +0000
@@ -84,7 +84,7 @@
 interactively for diff switches.  Otherwise, the switches
 specified in `diff-switches' are passed to the diff command."
   (interactive
-   (let ((newf (buffer-file-name))
+   (let* ((newf (buffer-file-name))
          (oldf (file-newest-backup newf)))
      (setq newf (if (and newf (file-exists-p newf))
 		    (read-file-name





bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 23 Dec 2010 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 14 years and 185 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.