GNU bug report logs - #74661
[PATCH] Make time-stamp after-save-hooks buffer-local.

Previous Next

Package: automake;

Reported by: Collin Funk <collin.funk1 <at> gmail.com>

Date: Tue, 3 Dec 2024 03:28:02 UTC

Severity: normal

Tags: patch

Done: Karl Berry <karl <at> freefriends.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Karl Berry <karl <at> freefriends.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#74661: closed ([PATCH] Make time-stamp after-save-hooks
 buffer-local.)
Date: Tue, 03 Dec 2024 22:58:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Tue, 3 Dec 2024 15:57:17 -0700
with message-id <202412032257.4B3MvHKw600620 <at> freefriends.org>
and subject line Re: bug#74661: [PATCH] Make time-stamp after-save-hooks buffer-local.
has caused the debbugs.gnu.org bug report #74661,
regarding [PATCH] Make time-stamp after-save-hooks buffer-local.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
74661: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74661
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Collin Funk <collin.funk1 <at> gmail.com>
To: bug-automake <at> gnu.org
Subject: [PATCH] Make time-stamp after-save-hooks buffer-local.
Date: Mon, 02 Dec 2024 19:27:43 -0800
[Message part 3 (text/plain, inline)]
Hi,

I applied a similar patch like this to Gnulib a while ago.

Basically, the use of this in files:

    # eval: (add-hook 'before-save-hook 'time-stamp)

modifies the global before-save-hook for Emacs, i.e. even after closing
the file. This caused some annoyance because it wouldn't work with this
in your Emacs init file:

    (setq enable-local-variables :safe)

The solution to this is to use:

    # eval: (add-hook 'before-save-hook 'time-stamp nil t)

so it only enables it on the current buffer.

Collin

[0001-Make-time-stamp-after-save-hooks-buffer-local.patch (text/x-patch, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Karl Berry <karl <at> freefriends.org>
To: collin.funk1 <at> gmail.com
Cc: 74661 <at> debbugs.gnu.org
Subject: Re: bug#74661: [PATCH] Make time-stamp after-save-hooks buffer-local.
Date: Tue, 3 Dec 2024 15:57:17 -0700
Hi Collin - looks fine to me. Applied. Thank you for updating the
timestamps and providing the ChangeLog entry. --happy hacking, karl.


This bug report was last modified 228 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.