GNU bug report logs - #74661
[PATCH] Make time-stamp after-save-hooks buffer-local.

Previous Next

Package: automake;

Reported by: Collin Funk <collin.funk1 <at> gmail.com>

Date: Tue, 3 Dec 2024 03:28:02 UTC

Severity: normal

Tags: patch

Done: Karl Berry <karl <at> freefriends.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74661 in the body.
You can then email your comments to 74661 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-automake <at> gnu.org:
bug#74661; Package automake. (Tue, 03 Dec 2024 03:28:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Collin Funk <collin.funk1 <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-automake <at> gnu.org. (Tue, 03 Dec 2024 03:28:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Collin Funk <collin.funk1 <at> gmail.com>
To: bug-automake <at> gnu.org
Subject: [PATCH] Make time-stamp after-save-hooks buffer-local.
Date: Mon, 02 Dec 2024 19:27:43 -0800
[Message part 1 (text/plain, inline)]
Hi,

I applied a similar patch like this to Gnulib a while ago.

Basically, the use of this in files:

    # eval: (add-hook 'before-save-hook 'time-stamp)

modifies the global before-save-hook for Emacs, i.e. even after closing
the file. This caused some annoyance because it wouldn't work with this
in your Emacs init file:

    (setq enable-local-variables :safe)

The solution to this is to use:

    # eval: (add-hook 'before-save-hook 'time-stamp nil t)

so it only enables it on the current buffer.

Collin

[0001-Make-time-stamp-after-save-hooks-buffer-local.patch (text/x-patch, attachment)]

Information forwarded to bug-automake <at> gnu.org:
bug#74661; Package automake. (Tue, 03 Dec 2024 22:58:01 GMT) Full text and rfc822 format available.

Message #8 received at 74661 <at> debbugs.gnu.org (full text, mbox):

From: Karl Berry <karl <at> freefriends.org>
To: collin.funk1 <at> gmail.com
Cc: 74661 <at> debbugs.gnu.org
Subject: Re: bug#74661: [PATCH] Make time-stamp after-save-hooks buffer-local.
Date: Tue, 3 Dec 2024 15:57:17 -0700
Hi Collin - looks fine to me. Applied. Thank you for updating the
timestamps and providing the ChangeLog entry. --happy hacking, karl.




Reply sent to Karl Berry <karl <at> freefriends.org>:
You have taken responsibility. (Tue, 03 Dec 2024 22:58:02 GMT) Full text and rfc822 format available.

Notification sent to Collin Funk <collin.funk1 <at> gmail.com>:
bug acknowledged by developer. (Tue, 03 Dec 2024 22:58:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 01 Jan 2025 12:24:12 GMT) Full text and rfc822 format available.

This bug report was last modified 226 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.