GNU bug report logs - #74642
31.0.50; [Patch] Turn off current source line indicator when gdb buffer is killed

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#74642: closed (31.0.50; [Patch] Turn off current source line
 indicator when gdb buffer is killed)
Date: Thu, 12 Dec 2024 10:48:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 12 Dec 2024 12:47:13 +0200
with message-id <86zfl1yy8e.fsf <at> gnu.org>
and subject line Re: bug#74642: 31.0.50; [Patch] Turn off current source line indicator when gdb buffer is killed
has caused the debbugs.gnu.org bug report #74642,
regarding 31.0.50; [Patch] Turn off current source line indicator when gdb buffer is killed
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
74642: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74642
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Diancheng Wang <diancheng_wang <at> 163.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; [Patch] Turn off current source line indicator when gdb
 buffer is killed
Date: Mon, 02 Dec 2024 15:04:46 +0800

[hide-current-line-indicator-kill-buffer.patch (text/x-diff, attachment)]

[Message part 4 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: diancheng_wang <diancheng_wang <at> 163.com>
Cc: 74642-done <at> debbugs.gnu.org
Subject: Re: bug#74642: 31.0.50; [Patch] Turn off current source line
 indicator when gdb buffer is killed
Date: Thu, 12 Dec 2024 12:47:13 +0200

> Date: Mon, 9 Dec 2024 09:27:42 +0800 (CST)
> From: diancheng_wang  <diancheng_wang <at> 163.com>
> Cc: 74642 <at> debbugs.gnu.org
> 
> At 2024-12-07 21:25:20, "Eli Zaretskii" <eliz <at> gnu.org> wrote:
> 
> >> From: Diancheng Wang <diancheng_wang <at> 163.com>
> >> Cc: 74642 <at> debbugs.gnu.org
> >> Date: Thu, 05 Dec 2024 16:37:33 +0800
> >> 
> >> Eli Zaretskii <eliz <at> gnu.org> writes:
> >> 
> >> >> From: Diancheng Wang <diancheng_wang <at> 163.com>
> >> >> Cc: 74642 <at> debbugs.gnu.org
> >> >> Date: Thu, 05 Dec 2024 15:34:44 +0800
> >> >> 
> >> >> > Crystal ball says that the regression was caused by the change you
> >> >> > submitted (and I installed) in bug#73687.  It added a call to
> >> >> > gud-hide-current-line-indicator to gdb-starting and to gud-sentinel.
> >> >> > Could you try reverting those changes and see if that solves the
> >> >> > problem in Emacs 31?
> >> >> 
> >> >> Yes, There is a regression in my patch: the arrow on the source line is
> >> >> not stopped displaying when "*gud-myprogram" got killed. But Emacs 30
> >> >> and Emacs 31 still have another issue:
> >> >> gud-highlight-current-line-overlay is not destroyed when
> >> >> "*gud-myprogram*" got killed.
> >> >
> >> > As I already wrote, I don't see the problem in Emacs 30: when I kill
> >> > the *gud-myprogram* buffer, the arrow disappears.
> >> >
> >> >> To reproduce it, you need to evaluate (setq
> >> >> gud-highlight-current-line t).
> >> >
> >> > So in Emacs 30 this only happens when gud-highlight-current-line is
> >> > non-nil?
> >> 
> >> Yes, the highlighted current source line in source file is not
> >> un-highlighted when gud-highlight-current-line is non-nil.
> >> 
> >> >
> >> >> I updated my patch to fix this 2 issues, see attachment.
> >> >
> >> > Does this fix the problem with the current-line indicator (either on
> >> > the fringe or as overlay-arrow) in both Emacs 30 and Emacs 31?
> >> >
> >> > Thanks.
> >> 
> >> This patch depends on my previous patch, which is commit in master branch:
> >> 
> >> --8<---------------cut here---------------start------------->8---
> >> 
> >> commit bd5d84e5d3311e7ab4a7d0091d6c98365927d17a
> >> Author: Diancheng Wang <diancheng_wang <at> 163.com>
> >> Date:   Tue Oct 8 11:11:24 2024 +0800
> >> 
> >>     Stop highlighting current line when debuggee is running
> >> 
> >> --8<---------------cut here---------------end--------------->8---
> >> 
> >> To apply this fix, Emacs 30 needs this commit.
> >
> >OK.  But the master branch needs only your last patch, and does not
> >need the original patch you posted in this bug report, is that right?
> 
> Yes, that's right.

Thanks.  So I've now installed that patch on the master branch, and
I'm therefore closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.