GNU bug report logs - #74642
31.0.50; [Patch] Turn off current source line indicator when gdb buffer is killed

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74642 in the body.
You can then email your comments to 74642 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Diancheng Wang <diancheng_wang <at> 163.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; [Patch] Turn off current source line indicator when gdb
 buffer is killed
Date: Mon, 02 Dec 2024 15:04:46 +0800

[hide-current-line-indicator-kill-buffer.patch (text/x-diff, attachment)]

Message #8 received at 74642 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Diancheng Wang <diancheng_wang <at> 163.com>
Cc: 74642 <at> debbugs.gnu.org
Subject: Re: bug#74642: 31.0.50;
 [Patch] Turn off current source line indicator when gdb buffer is
 killed
Date: Mon, 02 Dec 2024 15:17:13 +0200

> From: Diancheng Wang <diancheng_wang <at> 163.com>
> Date: Mon, 02 Dec 2024 15:04:46 +0800
> 
> diff --git a/lisp/progmodes/gdb-mi.el b/lisp/progmodes/gdb-mi.el
> index b60e21ff0ae..110b9f5ed46 100644
> --- a/lisp/progmodes/gdb-mi.el
> +++ b/lisp/progmodes/gdb-mi.el
> @@ -5278,6 +5278,7 @@ gdb-reset
>                (setq gud-minor-mode nil)
>                (kill-local-variable 'tool-bar-map)
>                (kill-local-variable 'gdb-define-alist))))))
> +  (gud-hide-current-line-indicator t)
>    (setq gdb-disassembly-position nil)
>    (setq overlay-arrow-variable-list
>          (delq 'gdb-disassembly-position overlay-arrow-variable-list))
> diff --git a/lisp/progmodes/gud.el b/lisp/progmodes/gud.el
> index a4e611277e4..ffd4dd70762 100644
> --- a/lisp/progmodes/gud.el
> +++ b/lisp/progmodes/gud.el
> @@ -3017,7 +3017,8 @@ gud-reset
>        (with-current-buffer buffer
>  	(when gud-minor-mode
>  	  (setq gud-minor-mode nil)
> -	  (kill-local-variable 'tool-bar-map))))))
> +	  (kill-local-variable 'tool-bar-map)))))
> +    (gud-hide-current-line-indicator t))
>  
>  (defun gud-display-frame ()
>    "Find and obey the last filename-and-line marker from the debugger.

Thanks, but can you please describe the scenario in which the
indicator is not removed?  I guess I don't really understand what you
mean by "gdb buffer is killed": what I tried is simply end the
debugging session by typing "q RET" at the GDB prompt.  And that
removed the indicator.

Message #11 received at 74642 <at> debbugs.gnu.org (full text, mbox):

From: Diancheng Wang <diancheng_wang <at> 163.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 74642 <at> debbugs.gnu.org
Subject: Re: bug#74642: 31.0.50; [Patch] Turn off current source line
 indicator when gdb buffer is killed
Date: Tue, 03 Dec 2024 10:04:30 +0800

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Diancheng Wang <diancheng_wang <at> 163.com>
>> Date: Mon, 02 Dec 2024 15:04:46 +0800
>> 
>> diff --git a/lisp/progmodes/gdb-mi.el b/lisp/progmodes/gdb-mi.el
>> index b60e21ff0ae..110b9f5ed46 100644
>> --- a/lisp/progmodes/gdb-mi.el
>> +++ b/lisp/progmodes/gdb-mi.el
>> @@ -5278,6 +5278,7 @@ gdb-reset
>>                (setq gud-minor-mode nil)
>>                (kill-local-variable 'tool-bar-map)
>>                (kill-local-variable 'gdb-define-alist))))))
>> +  (gud-hide-current-line-indicator t)
>>    (setq gdb-disassembly-position nil)
>>    (setq overlay-arrow-variable-list
>>          (delq 'gdb-disassembly-position overlay-arrow-variable-list))
>> diff --git a/lisp/progmodes/gud.el b/lisp/progmodes/gud.el
>> index a4e611277e4..ffd4dd70762 100644
>> --- a/lisp/progmodes/gud.el
>> +++ b/lisp/progmodes/gud.el
>> @@ -3017,7 +3017,8 @@ gud-reset
>>        (with-current-buffer buffer
>>  	(when gud-minor-mode
>>  	  (setq gud-minor-mode nil)
>> -	  (kill-local-variable 'tool-bar-map))))))
>> +	  (kill-local-variable 'tool-bar-map)))))
>> +    (gud-hide-current-line-indicator t))
>>  
>>  (defun gud-display-frame ()
>>    "Find and obey the last filename-and-line marker from the debugger.
>
> Thanks, but can you please describe the scenario in which the
> indicator is not removed?  I guess I don't really understand what you
> mean by "gdb buffer is killed": what I tried is simply end the
> debugging session by typing "q RET" at the GDB prompt.  And that
> removed the indicator.

Hi,

Sorry for confusing. I mean killing GDB interactive buffer directly by
typing "C-k RET" when gdb is stopped on a source line. The indicator is
not removed.

Message #14 received at 74642 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Diancheng Wang <diancheng_wang <at> 163.com>
Cc: 74642 <at> debbugs.gnu.org
Subject: Re: bug#74642: 31.0.50; [Patch] Turn off current source line
 indicator when gdb buffer is killed
Date: Tue, 03 Dec 2024 14:32:57 +0200

> From: Diancheng Wang <diancheng_wang <at> 163.com>
> Cc: 74642 <at> debbugs.gnu.org
> Date: Tue, 03 Dec 2024 10:04:30 +0800
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Thanks, but can you please describe the scenario in which the
> > indicator is not removed?  I guess I don't really understand what you
> > mean by "gdb buffer is killed": what I tried is simply end the
> > debugging session by typing "q RET" at the GDB prompt.  And that
> > removed the indicator.
> 
> Hi,
> 
> Sorry for confusing. I mean killing GDB interactive buffer directly by
> typing "C-k RET" when gdb is stopped on a source line. The indicator is
> not removed.

I guess you mean "C-x k RET"?

When I do that, Emacs asks me whether to kill the process associated
with the buffer, and if I say YES, the indicator does disappear
(sometimes after a second, which I guess is needed for Emacs to kill
the process).  Isn't that what you see?

Message #17 received at 74642 <at> debbugs.gnu.org (full text, mbox):

From: Diancheng Wang <diancheng_wang <at> 163.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 74642 <at> debbugs.gnu.org
Subject: Re: bug#74642: 31.0.50; [Patch] Turn off current source line
 indicator when gdb buffer is killed
Date: Wed, 04 Dec 2024 16:22:51 +0800

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Diancheng Wang <diancheng_wang <at> 163.com>
>> Cc: 74642 <at> debbugs.gnu.org
>> Date: Tue, 03 Dec 2024 10:04:30 +0800
>> 
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>> 
>> > Thanks, but can you please describe the scenario in which the
>> > indicator is not removed?  I guess I don't really understand what you
>> > mean by "gdb buffer is killed": what I tried is simply end the
>> > debugging session by typing "q RET" at the GDB prompt.  And that
>> > removed the indicator.
>> 
>> Hi,
>> 
>> Sorry for confusing. I mean killing GDB interactive buffer directly by
>> typing "C-k RET" when gdb is stopped on a source line. The indicator is
>> not removed.
>
> I guess you mean "C-x k RET"?

Yes, I mean "C-x k RET"

>
> When I do that, Emacs asks me whether to kill the process associated
> with the buffer, and if I say YES, the indicator does disappear

Yes, the steps are same with me.

> (sometimes after a second, which I guess is needed for Emacs to kill
> the process).  Isn't that what you see?

No, the indicator does not disappear after I killed "*gud-myprogram*" buffer.
By the way I started emacs using "emacs -Q". The attachment is my
running emacs information (the buffer content created by
report-emacs-bug)

[emacs-info (application/octet-stream, attachment)]

Message #20 received at 74642 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Diancheng Wang <diancheng_wang <at> 163.com>
Cc: 74642 <at> debbugs.gnu.org
Subject: Re: bug#74642: 31.0.50; [Patch] Turn off current source line
 indicator when gdb buffer is killed
Date: Wed, 04 Dec 2024 15:41:18 +0200

> From: Diancheng Wang <diancheng_wang <at> 163.com>
> Cc: 74642 <at> debbugs.gnu.org
> Date: Wed, 04 Dec 2024 16:22:51 +0800
> 
> > I guess you mean "C-x k RET"?
> 
> Yes, I mean "C-x k RET"
> 
> >
> > When I do that, Emacs asks me whether to kill the process associated
> > with the buffer, and if I say YES, the indicator does disappear
> 
> Yes, the steps are same with me.
> 
> > (sometimes after a second, which I guess is needed for Emacs to kill
> > the process).  Isn't that what you see?
> 
> No, the indicator does not disappear after I killed "*gud-myprogram*" buffer.
> By the way I started emacs using "emacs -Q".

So did I.

> The attachment is my running emacs information (the buffer content
> created by report-emacs-bug)

Looks like some kind of regression in Emacs 31.  It works in Emacs 30.
If you could bisect to find the offending commit, it will be
appreciated.

Thanks.

Message #23 received at 74642 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: diancheng_wang <at> 163.com
Cc: 74642 <at> debbugs.gnu.org
Subject: Re: bug#74642: 31.0.50;
 [Patch] Turn off current source line indicator when gdb buffer is
 killed
Date: Wed, 04 Dec 2024 21:11:35 +0200

> Cc: 74642 <at> debbugs.gnu.org
> Date: Wed, 04 Dec 2024 15:41:18 +0200
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> > From: Diancheng Wang <diancheng_wang <at> 163.com>
> > Cc: 74642 <at> debbugs.gnu.org
> > Date: Wed, 04 Dec 2024 16:22:51 +0800
> > 
> > > I guess you mean "C-x k RET"?
> > 
> > Yes, I mean "C-x k RET"
> > 
> > >
> > > When I do that, Emacs asks me whether to kill the process associated
> > > with the buffer, and if I say YES, the indicator does disappear
> > 
> > Yes, the steps are same with me.
> > 
> > > (sometimes after a second, which I guess is needed for Emacs to kill
> > > the process).  Isn't that what you see?
> > 
> > No, the indicator does not disappear after I killed "*gud-myprogram*" buffer.
> > By the way I started emacs using "emacs -Q".
> 
> So did I.
> 
> > The attachment is my running emacs information (the buffer content
> > created by report-emacs-bug)
> 
> Looks like some kind of regression in Emacs 31.  It works in Emacs 30.
> If you could bisect to find the offending commit, it will be
> appreciated.

Crystal ball says that the regression was caused by the change you
submitted (and I installed) in bug#73687.  It added a call to
gud-hide-current-line-indicator to gdb-starting and to gud-sentinel.
Could you try reverting those changes and see if that solves the
problem in Emacs 31?

Message #26 received at 74642 <at> debbugs.gnu.org (full text, mbox):

From: Diancheng Wang <diancheng_wang <at> 163.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 74642 <at> debbugs.gnu.org
Subject: Re: bug#74642: 31.0.50; [Patch] Turn off current source line
 indicator when gdb buffer is killed
Date: Thu, 05 Dec 2024 15:34:44 +0800

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: 74642 <at> debbugs.gnu.org
>> Date: Wed, 04 Dec 2024 15:41:18 +0200
>> From: Eli Zaretskii <eliz <at> gnu.org>
>> 
>> > From: Diancheng Wang <diancheng_wang <at> 163.com>
>> > Cc: 74642 <at> debbugs.gnu.org
>> > Date: Wed, 04 Dec 2024 16:22:51 +0800
>> > 
>> > > I guess you mean "C-x k RET"?
>> > 
>> > Yes, I mean "C-x k RET"
>> > 
>> > >
>> > > When I do that, Emacs asks me whether to kill the process associated
>> > > with the buffer, and if I say YES, the indicator does disappear
>> > 
>> > Yes, the steps are same with me.
>> > 
>> > > (sometimes after a second, which I guess is needed for Emacs to kill
>> > > the process).  Isn't that what you see?
>> > 
>> > No, the indicator does not disappear after I killed "*gud-myprogram*" buffer.
>> > By the way I started emacs using "emacs -Q".
>> 
>> So did I.
>> 
>> > The attachment is my running emacs information (the buffer content
>> > created by report-emacs-bug)
>> 
>> Looks like some kind of regression in Emacs 31.  It works in Emacs 30.
>> If you could bisect to find the offending commit, it will be
>> appreciated.
>
> Crystal ball says that the regression was caused by the change you
> submitted (and I installed) in bug#73687.  It added a call to
> gud-hide-current-line-indicator to gdb-starting and to gud-sentinel.
> Could you try reverting those changes and see if that solves the
> problem in Emacs 31?

Yes, There is a regression in my patch: the arrow on the source line is
not stopped displaying when "*gud-myprogram" got killed. But Emacs 30
and Emacs 31 still have another issue:
gud-highlight-current-line-overlay is not destroyed when
"*gud-myprogram*" got killed. To reproduce it, you need to evaluate (setq
gud-highlight-current-line t). I updated my patch to fix this 2 issues,
see attachment.

[stop-highlight-when-gud-buffer-killed.patch (text/x-diff, inline)]

diff --git a/lisp/progmodes/gud.el b/lisp/progmodes/gud.el
index a4e611277e4..70daa087c2b 100644
--- a/lisp/progmodes/gud.el
+++ b/lisp/progmodes/gud.el
@@ -2962,6 +2962,8 @@ gud-hide-current-line-indicator
 (defun gud-sentinel (proc msg)
   (cond ((null (buffer-name (process-buffer proc)))
 	 ;; buffer killed
+	 ;; Stop displaying an arrow and highlight overlay in a source file.
+	 (gud-hide-current-line-indicator t)
 	 (set-process-buffer proc nil)
 	 (if (and (boundp 'speedbar-initial-expansion-list-name)
 		  (string-equal speedbar-initial-expansion-list-name "GUD"))

Message #29 received at 74642 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Diancheng Wang <diancheng_wang <at> 163.com>
Cc: 74642 <at> debbugs.gnu.org
Subject: Re: bug#74642: 31.0.50; [Patch] Turn off current source line
 indicator when gdb buffer is killed
Date: Thu, 05 Dec 2024 09:55:45 +0200

> From: Diancheng Wang <diancheng_wang <at> 163.com>
> Cc: 74642 <at> debbugs.gnu.org
> Date: Thu, 05 Dec 2024 15:34:44 +0800
> 
> > Crystal ball says that the regression was caused by the change you
> > submitted (and I installed) in bug#73687.  It added a call to
> > gud-hide-current-line-indicator to gdb-starting and to gud-sentinel.
> > Could you try reverting those changes and see if that solves the
> > problem in Emacs 31?
> 
> Yes, There is a regression in my patch: the arrow on the source line is
> not stopped displaying when "*gud-myprogram" got killed. But Emacs 30
> and Emacs 31 still have another issue:
> gud-highlight-current-line-overlay is not destroyed when
> "*gud-myprogram*" got killed.

As I already wrote, I don't see the problem in Emacs 30: when I kill
the *gud-myprogram* buffer, the arrow disappears.

> To reproduce it, you need to evaluate (setq
> gud-highlight-current-line t).

So in Emacs 30 this only happens when gud-highlight-current-line is
non-nil?

> I updated my patch to fix this 2 issues, see attachment.

Does this fix the problem with the current-line indicator (either on
the fringe or as overlay-arrow) in both Emacs 30 and Emacs 31?

Thanks.

Message #32 received at 74642 <at> debbugs.gnu.org (full text, mbox):

From: Diancheng Wang <diancheng_wang <at> 163.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 74642 <at> debbugs.gnu.org
Subject: Re: bug#74642: 31.0.50; [Patch] Turn off current source line
 indicator when gdb buffer is killed
Date: Thu, 05 Dec 2024 16:37:33 +0800

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Diancheng Wang <diancheng_wang <at> 163.com>
>> Cc: 74642 <at> debbugs.gnu.org
>> Date: Thu, 05 Dec 2024 15:34:44 +0800
>> 
>> > Crystal ball says that the regression was caused by the change you
>> > submitted (and I installed) in bug#73687.  It added a call to
>> > gud-hide-current-line-indicator to gdb-starting and to gud-sentinel.
>> > Could you try reverting those changes and see if that solves the
>> > problem in Emacs 31?
>> 
>> Yes, There is a regression in my patch: the arrow on the source line is
>> not stopped displaying when "*gud-myprogram" got killed. But Emacs 30
>> and Emacs 31 still have another issue:
>> gud-highlight-current-line-overlay is not destroyed when
>> "*gud-myprogram*" got killed.
>
> As I already wrote, I don't see the problem in Emacs 30: when I kill
> the *gud-myprogram* buffer, the arrow disappears.
>
>> To reproduce it, you need to evaluate (setq
>> gud-highlight-current-line t).
>
> So in Emacs 30 this only happens when gud-highlight-current-line is
> non-nil?

Yes, the highlighted current source line in source file is not
un-highlighted when gud-highlight-current-line is non-nil.

>
>> I updated my patch to fix this 2 issues, see attachment.
>
> Does this fix the problem with the current-line indicator (either on
> the fringe or as overlay-arrow) in both Emacs 30 and Emacs 31?
>
> Thanks.

This patch depends on my previous patch, which is commit in master branch:

--8<---------------cut here---------------start------------->8---

commit bd5d84e5d3311e7ab4a7d0091d6c98365927d17a
Author: Diancheng Wang <diancheng_wang <at> 163.com>
Date:   Tue Oct 8 11:11:24 2024 +0800

    Stop highlighting current line when debuggee is running

--8<---------------cut here---------------end--------------->8---

To apply this fix, Emacs 30 needs this commit.

Message #35 received at 74642 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Diancheng Wang <diancheng_wang <at> 163.com>
Cc: 74642 <at> debbugs.gnu.org
Subject: Re: bug#74642: 31.0.50; [Patch] Turn off current source line
 indicator when gdb buffer is killed
Date: Sat, 07 Dec 2024 15:25:20 +0200

> From: Diancheng Wang <diancheng_wang <at> 163.com>
> Cc: 74642 <at> debbugs.gnu.org
> Date: Thu, 05 Dec 2024 16:37:33 +0800
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> From: Diancheng Wang <diancheng_wang <at> 163.com>
> >> Cc: 74642 <at> debbugs.gnu.org
> >> Date: Thu, 05 Dec 2024 15:34:44 +0800
> >> 
> >> > Crystal ball says that the regression was caused by the change you
> >> > submitted (and I installed) in bug#73687.  It added a call to
> >> > gud-hide-current-line-indicator to gdb-starting and to gud-sentinel.
> >> > Could you try reverting those changes and see if that solves the
> >> > problem in Emacs 31?
> >> 
> >> Yes, There is a regression in my patch: the arrow on the source line is
> >> not stopped displaying when "*gud-myprogram" got killed. But Emacs 30
> >> and Emacs 31 still have another issue:
> >> gud-highlight-current-line-overlay is not destroyed when
> >> "*gud-myprogram*" got killed.
> >
> > As I already wrote, I don't see the problem in Emacs 30: when I kill
> > the *gud-myprogram* buffer, the arrow disappears.
> >
> >> To reproduce it, you need to evaluate (setq
> >> gud-highlight-current-line t).
> >
> > So in Emacs 30 this only happens when gud-highlight-current-line is
> > non-nil?
> 
> Yes, the highlighted current source line in source file is not
> un-highlighted when gud-highlight-current-line is non-nil.
> 
> >
> >> I updated my patch to fix this 2 issues, see attachment.
> >
> > Does this fix the problem with the current-line indicator (either on
> > the fringe or as overlay-arrow) in both Emacs 30 and Emacs 31?
> >
> > Thanks.
> 
> This patch depends on my previous patch, which is commit in master branch:
> 
> --8<---------------cut here---------------start------------->8---
> 
> commit bd5d84e5d3311e7ab4a7d0091d6c98365927d17a
> Author: Diancheng Wang <diancheng_wang <at> 163.com>
> Date:   Tue Oct 8 11:11:24 2024 +0800
> 
>     Stop highlighting current line when debuggee is running
> 
> --8<---------------cut here---------------end--------------->8---
> 
> To apply this fix, Emacs 30 needs this commit.

OK.  But the master branch needs only your last patch, and does not
need the original patch you posted in this bug report, is that right?

Message #38 received at 74642 <at> debbugs.gnu.org (full text, mbox):

From: diancheng_wang  <diancheng_wang <at> 163.com>
To: "Eli Zaretskii" <eliz <at> gnu.org>
Cc: 74642 <at> debbugs.gnu.org
Subject: Re:Re: bug#74642: 31.0.50; [Patch] Turn off current source line
 indicator when gdb buffer is killed
Date: Mon, 9 Dec 2024 09:27:42 +0800 (CST)

[Message part 1 (text/plain, inline)]

At 2024-12-07 21:25:20, "Eli Zaretskii" <eliz <at> gnu.org> wrote:

>> From: Diancheng Wang <diancheng_wang <at> 163.com>
>> Cc: 74642 <at> debbugs.gnu.org
>> Date: Thu, 05 Dec 2024 16:37:33 +0800
>> 
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>> 
>> >> From: Diancheng Wang <diancheng_wang <at> 163.com>
>> >> Cc: 74642 <at> debbugs.gnu.org
>> >> Date: Thu, 05 Dec 2024 15:34:44 +0800
>> >> 
>> >> > Crystal ball says that the regression was caused by the change you
>> >> > submitted (and I installed) in bug#73687.  It added a call to
>> >> > gud-hide-current-line-indicator to gdb-starting and to gud-sentinel.
>> >> > Could you try reverting those changes and see if that solves the
>> >> > problem in Emacs 31?
>> >> 
>> >> Yes, There is a regression in my patch: the arrow on the source line is
>> >> not stopped displaying when "*gud-myprogram" got killed. But Emacs 30
>> >> and Emacs 31 still have another issue:
>> >> gud-highlight-current-line-overlay is not destroyed when
>> >> "*gud-myprogram*" got killed.
>> >
>> > As I already wrote, I don't see the problem in Emacs 30: when I kill
>> > the *gud-myprogram* buffer, the arrow disappears.
>> >
>> >> To reproduce it, you need to evaluate (setq
>> >> gud-highlight-current-line t).
>> >
>> > So in Emacs 30 this only happens when gud-highlight-current-line is
>> > non-nil?
>> 
>> Yes, the highlighted current source line in source file is not
>> un-highlighted when gud-highlight-current-line is non-nil.
>> 
>> >
>> >> I updated my patch to fix this 2 issues, see attachment.
>> >
>> > Does this fix the problem with the current-line indicator (either on
>> > the fringe or as overlay-arrow) in both Emacs 30 and Emacs 31?
>> >
>> > Thanks.
>> 
>> This patch depends on my previous patch, which is commit in master branch:
>> 
>> --8<---------------cut here---------------start------------->8---
>> 
>> commit bd5d84e5d3311e7ab4a7d0091d6c98365927d17a
>> Author: Diancheng Wang <diancheng_wang <at> 163.com>
>> Date:   Tue Oct 8 11:11:24 2024 +0800
>> 
>>     Stop highlighting current line when debuggee is running
>> 
>> --8<---------------cut here---------------end--------------->8---
>> 
>> To apply this fix, Emacs 30 needs this commit.
>
>OK.  But the master branch needs only your last patch, and does not

>need the original patch you posted in this bug report, is that right?


Yes, that's right.

[Message part 2 (text/html, inline)]

Message #43 received at 74642-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: diancheng_wang <diancheng_wang <at> 163.com>
Cc: 74642-done <at> debbugs.gnu.org
Subject: Re: bug#74642: 31.0.50; [Patch] Turn off current source line
 indicator when gdb buffer is killed
Date: Thu, 12 Dec 2024 12:47:13 +0200

> Date: Mon, 9 Dec 2024 09:27:42 +0800 (CST)
> From: diancheng_wang  <diancheng_wang <at> 163.com>
> Cc: 74642 <at> debbugs.gnu.org
> 
> At 2024-12-07 21:25:20, "Eli Zaretskii" <eliz <at> gnu.org> wrote:
> 
> >> From: Diancheng Wang <diancheng_wang <at> 163.com>
> >> Cc: 74642 <at> debbugs.gnu.org
> >> Date: Thu, 05 Dec 2024 16:37:33 +0800
> >> 
> >> Eli Zaretskii <eliz <at> gnu.org> writes:
> >> 
> >> >> From: Diancheng Wang <diancheng_wang <at> 163.com>
> >> >> Cc: 74642 <at> debbugs.gnu.org
> >> >> Date: Thu, 05 Dec 2024 15:34:44 +0800
> >> >> 
> >> >> > Crystal ball says that the regression was caused by the change you
> >> >> > submitted (and I installed) in bug#73687.  It added a call to
> >> >> > gud-hide-current-line-indicator to gdb-starting and to gud-sentinel.
> >> >> > Could you try reverting those changes and see if that solves the
> >> >> > problem in Emacs 31?
> >> >> 
> >> >> Yes, There is a regression in my patch: the arrow on the source line is
> >> >> not stopped displaying when "*gud-myprogram" got killed. But Emacs 30
> >> >> and Emacs 31 still have another issue:
> >> >> gud-highlight-current-line-overlay is not destroyed when
> >> >> "*gud-myprogram*" got killed.
> >> >
> >> > As I already wrote, I don't see the problem in Emacs 30: when I kill
> >> > the *gud-myprogram* buffer, the arrow disappears.
> >> >
> >> >> To reproduce it, you need to evaluate (setq
> >> >> gud-highlight-current-line t).
> >> >
> >> > So in Emacs 30 this only happens when gud-highlight-current-line is
> >> > non-nil?
> >> 
> >> Yes, the highlighted current source line in source file is not
> >> un-highlighted when gud-highlight-current-line is non-nil.
> >> 
> >> >
> >> >> I updated my patch to fix this 2 issues, see attachment.
> >> >
> >> > Does this fix the problem with the current-line indicator (either on
> >> > the fringe or as overlay-arrow) in both Emacs 30 and Emacs 31?
> >> >
> >> > Thanks.
> >> 
> >> This patch depends on my previous patch, which is commit in master branch:
> >> 
> >> --8<---------------cut here---------------start------------->8---
> >> 
> >> commit bd5d84e5d3311e7ab4a7d0091d6c98365927d17a
> >> Author: Diancheng Wang <diancheng_wang <at> 163.com>
> >> Date:   Tue Oct 8 11:11:24 2024 +0800
> >> 
> >>     Stop highlighting current line when debuggee is running
> >> 
> >> --8<---------------cut here---------------end--------------->8---
> >> 
> >> To apply this fix, Emacs 30 needs this commit.
> >
> >OK.  But the master branch needs only your last patch, and does not
> >need the original patch you posted in this bug report, is that right?
> 
> Yes, that's right.

Thanks.  So I've now installed that patch on the master branch, and
I'm therefore closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.