GNU bug report logs - #74642
31.0.50; [Patch] Turn off current source line indicator when gdb buffer is killed

Previous Next

Full log

Message #29 received at 74642 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Diancheng Wang <diancheng_wang <at> 163.com>
Cc: 74642 <at> debbugs.gnu.org
Subject: Re: bug#74642: 31.0.50; [Patch] Turn off current source line
 indicator when gdb buffer is killed
Date: Thu, 05 Dec 2024 09:55:45 +0200

> From: Diancheng Wang <diancheng_wang <at> 163.com>
> Cc: 74642 <at> debbugs.gnu.org
> Date: Thu, 05 Dec 2024 15:34:44 +0800
> 
> > Crystal ball says that the regression was caused by the change you
> > submitted (and I installed) in bug#73687.  It added a call to
> > gud-hide-current-line-indicator to gdb-starting and to gud-sentinel.
> > Could you try reverting those changes and see if that solves the
> > problem in Emacs 31?
> 
> Yes, There is a regression in my patch: the arrow on the source line is
> not stopped displaying when "*gud-myprogram" got killed. But Emacs 30
> and Emacs 31 still have another issue:
> gud-highlight-current-line-overlay is not destroyed when
> "*gud-myprogram*" got killed.

As I already wrote, I don't see the problem in Emacs 30: when I kill
the *gud-myprogram* buffer, the arrow disappears.

> To reproduce it, you need to evaluate (setq
> gud-highlight-current-line t).

So in Emacs 30 this only happens when gud-highlight-current-line is
non-nil?

> I updated my patch to fix this 2 issues, see attachment.

Does this fix the problem with the current-line indicator (either on
the fringe or as overlay-arrow) in both Emacs 30 and Emacs 31?

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.