GNU bug report logs - #74617
30.0.92; ffap-menu always displays the *Completions* buffer

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#74617: closed (30.0.92; ffap-menu always displays the
 *Completions* buffer)
Date: Sat, 14 Dec 2024 12:53:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 14 Dec 2024 13:51:56 +0100
with message-id <87r06aig0j.fsf <at> daniel-mendler.de>
and subject line Re: bug#74617: 30.0.92; ffap-menu always displays the *Completions* buffer
has caused the debbugs.gnu.org bug report #74617,
regarding 30.0.92; ffap-menu always displays the *Completions* buffer
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
74617: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74617
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.92; ffap-menu always displays the *Completions* buffer
Date: Sat, 30 Nov 2024 08:02:20 +0100

`ffap-menu' automatically displays the *Completions* buffer by calling
`minibuffer-completion-help'. If an alternative minibuffer completion
system like Icomplete or Vertico is used, the *Completions* buffer is
not needed since the candidates are already displayed in the minibuffer.

I propose to either detect these alternative completion systems (e.g.,
by checking the value of the completing-read-function and/or the mode
variables) or to provide a way to disable the call to
`minibuffer-completion-help'.

Since the same problem is present in tmm.el, maybe a generic solution
could be provided by minibuffer.el? Option 1: A function
`minibuffer-completion-help-if-needed' could call
`minibuffer-completion-help' only if no other completion system is
detected. Option 2: A new function
`completing-read-display-help-function' could be added which defaults to
`minibuffer-completion-help' and which could be set to nil/ignore by
alternative completion UIs like Vertico. This function could be used by
tmm/ffap. Option 3: A new variable `minibuffer-inhibit-completion-help'
could be added which is checked by `minibuffer-completion-help' and
which could be set to t by alternative completion UIs.

I am happy to provide a patch for any of these approaches.

[Message part 3 (message/rfc822, inline)]

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: 74617-done <at> debbugs.gnu.org
Subject: Re: bug#74617: 30.0.92; ffap-menu always displays the *Completions*
 buffer
Date: Sat, 14 Dec 2024 13:51:56 +0100

Fixed by `completion-eager-display'. See bug#74616.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.