GNU bug report logs - #74618
[PATCH] gnu: lcov: disable parallel tests

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74618 in the body.
You can then email your comments to 74618 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ryan Sundberg <ryan <at> arctype.co>
To: guix-patches <at> gnu.org
Cc: Ryan Sundberg <ryan <at> arctype.co>
Subject: [PATCH] gnu: lcov: disable parallel tests
Date: Fri, 29 Nov 2024 23:33:30 -0800

`make check` is not reliable for lcov when run in parallel
(e.g. `make -j 24 check`). Disable parallelism for the test suite.

* gnu/packages/code (lcov): Set #:parallel-tests? #f

Signed-off-by: Ryan Sundberg <ryan <at> arctype.co>
Change-Id: Ibb3618c4786dfbb50b90e725297947458115347c
---
 gnu/packages/code.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/code.scm b/gnu/packages/code.scm
index 04ca4dfd6b..6ac514a5b5 100644
--- a/gnu/packages/code.scm
+++ b/gnu/packages/code.scm
@@ -556,6 +556,7 @@ (define-public lcov
      '(#:test-target "test"
        #:make-flags (list (string-append "PREFIX="
                                          (assoc-ref %outputs "out")))
+       #:parallel-tests? #f
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'patch-references-to-commands

base-commit: ce877a777e6ec089dc347e9883387d3080b471cf
-- 
2.41.0

Message #8 received at 74618 <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: Ryan Sundberg via Guix-patches via <guix-patches <at> gnu.org>
Cc: Ryan Sundberg <ryan <at> arctype.co>, 74618 <at> debbugs.gnu.org
Subject: Re: [bug#74618] [PATCH] gnu: lcov: disable parallel tests
Date: Sun, 01 Dec 2024 18:45:28 +0800

[Message part 1 (text/plain, inline)]

Ryan Sundberg via Guix-patches via <guix-patches <at> gnu.org> writes:

> `make check` is not reliable for lcov when run in parallel
> (e.g. `make -j 24 check`). Disable parallelism for the test suite.

Please also write this in the comments of the code. Make it easy for
people to know later

>
> * gnu/packages/code (lcov): Set #:parallel-tests? #f
>
> Signed-off-by: Ryan Sundberg <ryan <at> arctype.co>
> Change-Id: Ibb3618c4786dfbb50b90e725297947458115347c
> ---
>  gnu/packages/code.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/code.scm b/gnu/packages/code.scm
> index 04ca4dfd6b..6ac514a5b5 100644
> --- a/gnu/packages/code.scm
> +++ b/gnu/packages/code.scm
> @@ -556,6 +556,7 @@ (define-public lcov
>       '(#:test-target "test"
>         #:make-flags (list (string-append "PREFIX="
>                                           (assoc-ref %outputs "out")))
> +       #:parallel-tests? #f
>         #:phases
>         (modify-phases %standard-phases
>           (add-after 'unpack 'patch-references-to-commands
>
> base-commit: ce877a777e6ec089dc347e9883387d3080b471cf

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 74618 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Sundberg <ryan <at> arctype.co>
To: 74618 <at> debbugs.gnu.org
Cc: Ryan Sundberg <ryan <at> arctype.co>
Subject: [PATCH] gnu: lcov: disable parallel tests
Date: Sun,  1 Dec 2024 21:29:39 -0800

`make check` is not reliable for lcov when run in parallel
(e.g. `make -j 24 check`). Disable parallelism for the test suite.

* gnu/packages/code (lcov): Set #:parallel-tests? #f

Signed-off-by: Ryan Sundberg <ryan <at> arctype.co>
Change-Id: Ibb3618c4786dfbb50b90e725297947458115347c
---
 gnu/packages/code.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/code.scm b/gnu/packages/code.scm
index 04ca4dfd6b..2ad1d8616a 100644
--- a/gnu/packages/code.scm
+++ b/gnu/packages/code.scm
@@ -556,6 +556,9 @@ (define-public lcov
      '(#:test-target "test"
        #:make-flags (list (string-append "PREFIX="
                                          (assoc-ref %outputs "out")))
+       ;; This test suite has race conditions in its scripts which make it
+       ;; unreliable when run in parallel.
+       #:parallel-tests? #f
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'patch-references-to-commands

base-commit: ce877a777e6ec089dc347e9883387d3080b471cf
-- 
2.41.0

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: Ryan Sundberg via Guix-patches via <guix-patches <at> gnu.org>
Cc: Ryan Sundberg <ryan <at> arctype.co>, 74618-done <at> debbugs.gnu.org
Subject: Re: [bug#74618] [PATCH] gnu: lcov: disable parallel tests
Date: Sat, 07 Dec 2024 09:41:00 +0800

[Message part 1 (text/plain, inline)]

please use [PATCH v2] next.

Ryan Sundberg via Guix-patches via <guix-patches <at> gnu.org> writes:

> `make check` is not reliable for lcov when run in parallel
> (e.g. `make -j 24 check`). Disable parallelism for the test suite.
>
> * gnu/packages/code (lcov): Set #:parallel-tests? #f
>
> Signed-off-by: Ryan Sundberg <ryan <at> arctype.co>
> Change-Id: Ibb3618c4786dfbb50b90e725297947458115347c
> ---
>  gnu/packages/code.scm | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/gnu/packages/code.scm b/gnu/packages/code.scm
> index 04ca4dfd6b..2ad1d8616a 100644
> --- a/gnu/packages/code.scm
> +++ b/gnu/packages/code.scm
> @@ -556,6 +556,9 @@ (define-public lcov
>       '(#:test-target "test"
>         #:make-flags (list (string-append "PREFIX="
>                                           (assoc-ref %outputs "out")))
> +       ;; This test suite has race conditions in its scripts which make it
> +       ;; unreliable when run in parallel.
> +       #:parallel-tests? #f
>         #:phases
>         (modify-phases %standard-phases
>           (add-after 'unpack 'patch-references-to-commands
>
> base-commit: ce877a777e6ec089dc347e9883387d3080b471cf

pushed, closing.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.