GNU bug report logs - #74568
[PATCH] add scenefx

Previous Next

Full log

View this message in rfc822 format

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: Josep Bigorra <jjbigorra <at> gmail.com>
Cc: 74568 <at> debbugs.gnu.org
Subject: [bug#74568] [PATCH] add scenefx
Date: Fri, 29 Nov 2024 17:45:32 +0800

[Message part 1 (text/plain, inline)]

Josep Bigorra <jjbigorra <at> gmail.com> writes:

> This is my first attempt to contribute! :) I want to update Swayfx to 0.4 after this, but first, scenefx must be in guix packages. Hopefully
> this will do?

please use plain-txt e-mail. and use `mumi send-email' or
`git send-email' to send patch. see
https://guix.gnu.org/manual/devel/en/html_node/Sending-a-Patch-Series.html#Single-Patches-1

>-    (name "sway")

If you do not modify the package, do not modify the indentation of the package

>+   (inputs (map (lambda (x) (specification->package x))
>+                `("basu"
>+                  "cairo"
>+                  "gdk-pixbuf"
>+                  "json-c"
>+                  "cmake"
>+                  "libevdev"
>+                  "libinput-minimal"
>+                  "libxkbcommon"
>+                  "pcre2"
>+                  "pkg-config"
>+                  "pcre2"
>+                  "wayland"
>+                  "libdrm"
>+                  "wlroots <at> 0.17.4")))

You cannot use specification->package in a package, use the scheme
variable.

many package is not needed, just pixman mesa libxkbcommon libdrm
wlroots-0.17. see meson.build.

and pkg-config usually is native-inputs, It need to actually run on
cross-compiling.

>+   (home-page "https://github.com/wlrfx/scenefx.git")

guix lint scenefx say scenefx <at> 0.1: permanent redirect from https://github.com/wlrfx/scenefx.git to https://github.com/wlrfx/scenefx.

so should https://github.com/wlrfx/scenefx.

>+   (synopsis "SceneFX")
>+   (description
>+    "SceneFX")

Please write useful synopsis and description
see https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html

After the completion of the modified like
https://issues.guix.gnu.org/74568#1

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.