GNU bug report logs - #74568
[PATCH] add scenefx

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74568 in the body.
You can then email your comments to 74568 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Josep Bigorra <jjbigorra <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] add scenefx
Date: Wed, 27 Nov 2024 22:30:54 +0100

[Message part 1 (text/plain, inline)]

This is my first attempt to contribute! :) I want to update Swayfx to 0.4
after this, but first, scenefx must be in guix packages. Hopefully this
will do?

[Message part 2 (text/html, inline)]

[0001-added-scenefx-to-Guix-packages.patch (text/x-patch, attachment)]

[0002-formatting.patch (text/x-patch, attachment)]

Message #8 received at 74568 <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: Josep Bigorra <jjbigorra <at> gmail.com>
Cc: 74568 <at> debbugs.gnu.org
Subject: Re: [bug#74568] [PATCH] add scenefx
Date: Fri, 29 Nov 2024 17:28:27 +0800

[Message part 1 (text/plain, inline)]

Josep Bigorra <jjbigorra <at> gmail.com> writes:

> This is my first attempt to contribute! :) I want to update Swayfx to 0.4 after this, but first, scenefx must be in
> guix packages. Hopefully this will do?
>
> [4. text/x-patch; 0001-added-scenefx-to-Guix-packages.patch]...
>
> [5. text/x-patch; 0002-formatting.patch]...

[0001-gnu-Add-scenefx.patch (text/x-patch, inline)]

From ae1ce49f82544ad2a8e48624072fc00f8989586b Mon Sep 17 00:00:00 2001
Message-ID: <ae1ce49f82544ad2a8e48624072fc00f8989586b.1732872470.git.zhengjunjie <at> iscas.ac.cn>
From: Josep Bigorra <jjbigorra <at> gmail.com>
Date: Wed, 27 Nov 2024 22:30:54 +0100
Subject: [PATCH] gnu: Add scenefx.

* gnu/packages/wm.scm (scenefx): New variable.

Signed-off-by: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
Change-Id: Ia91747cbec59226a83a020b5fedbfd99886c35df
---
 gnu/packages/wm.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 921f9750378..2ab6f88cd5b 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -76,6 +76,7 @@
 ;;; Copyright © 2024 dan <i <at> dan.games>
 ;;; Copyright © 2024 Wamm K. D. <jaft.r <at> outlook.com>
 ;;; Copyright © 2024 Ashish SHUKLA <ashish.is <at> lostca.se>
+;;; Copyright © 2024 Josep Bigorra <jjbigorra <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3969,3 +3970,32 @@ (define-public wf-config
 configuration files of Wayifre.  It can set key and mouse bindings,
 configure input, and customize Wayfire plugins.")
     (license license:expat)))
+
+(define-public scenefx
+  (package
+    (name "scenefx")
+    (version "0.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/wlrfx/scenefx")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1r7f8bprsn0mwlkmc8d14nr3iibljfyxypb4i06v66ghlngaw6dw"))))
+    (build-system meson-build-system)
+    (native-inputs (list pkg-config
+                         ;; for wayland-scanner.
+                         wayland))
+    (inputs (list pixman
+                  mesa
+                  libxkbcommon
+                  libdrm
+                  wlroots-0.17))
+    (home-page "https://github.com/wlrfx/scenefx")
+    (synopsis "Drop-in replacement for the wlroots scene API")
+    (description
+     "A drop-in replacement for the wlroots scene API that allows wayland
+compositors to render surfaces with eye-candy effects.")
+    (license license:expat)))

base-commit: c5421392081944d43db18fe04eafecec521f994a
prerequisite-patch-id: 87446432571a7ef03b5b1c5a831298c21b1b28a8
prerequisite-patch-id: fed79dd6ff68c92729413fc125b19314aa1bc3c4
-- 
2.46.0

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 74568 <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: Josep Bigorra <jjbigorra <at> gmail.com>
Cc: 74568 <at> debbugs.gnu.org
Subject: Re: [bug#74568] [PATCH] add scenefx
Date: Fri, 29 Nov 2024 17:45:32 +0800

[Message part 1 (text/plain, inline)]

Josep Bigorra <jjbigorra <at> gmail.com> writes:

> This is my first attempt to contribute! :) I want to update Swayfx to 0.4 after this, but first, scenefx must be in guix packages. Hopefully
> this will do?

please use plain-txt e-mail. and use `mumi send-email' or
`git send-email' to send patch. see
https://guix.gnu.org/manual/devel/en/html_node/Sending-a-Patch-Series.html#Single-Patches-1

>-    (name "sway")

If you do not modify the package, do not modify the indentation of the package

>+   (inputs (map (lambda (x) (specification->package x))
>+                `("basu"
>+                  "cairo"
>+                  "gdk-pixbuf"
>+                  "json-c"
>+                  "cmake"
>+                  "libevdev"
>+                  "libinput-minimal"
>+                  "libxkbcommon"
>+                  "pcre2"
>+                  "pkg-config"
>+                  "pcre2"
>+                  "wayland"
>+                  "libdrm"
>+                  "wlroots <at> 0.17.4")))

You cannot use specification->package in a package, use the scheme
variable.

many package is not needed, just pixman mesa libxkbcommon libdrm
wlroots-0.17. see meson.build.

and pkg-config usually is native-inputs, It need to actually run on
cross-compiling.

>+   (home-page "https://github.com/wlrfx/scenefx.git")

guix lint scenefx say scenefx <at> 0.1: permanent redirect from https://github.com/wlrfx/scenefx.git to https://github.com/wlrfx/scenefx.

so should https://github.com/wlrfx/scenefx.

>+   (synopsis "SceneFX")
>+   (description
>+    "SceneFX")

Please write useful synopsis and description
see https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html

After the completion of the modified like
https://issues.guix.gnu.org/74568#1

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 74568-done <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: Josep Bigorra <jjbigorra <at> gmail.com>
Cc: 74568-done <at> debbugs.gnu.org
Subject: Re: [bug#74568] [PATCH] add scenefx
Date: Sun, 01 Dec 2024 19:08:29 +0800

[Message part 1 (text/plain, inline)]

Zheng Junjie <zhengjunjie <at> iscas.ac.cn> writes:

> Josep Bigorra <jjbigorra <at> gmail.com> writes:
>
>> This is my first attempt to contribute! :) I want to update Swayfx
>> to 0.4 after this, but first, scenefx must be in
>> guix packages. Hopefully this will do?
>>
>> [4. text/x-patch; 0001-added-scenefx-to-Guix-packages.patch]...
>>
>> [5. text/x-patch; 0002-formatting.patch]...
>
>
> From ae1ce49f82544ad2a8e48624072fc00f8989586b Mon Sep 17 00:00:00 2001
> Message-ID: <ae1ce49f82544ad2a8e48624072fc00f8989586b.1732872470.git.zhengjunjie <at> iscas.ac.cn>
> From: Josep Bigorra <jjbigorra <at> gmail.com>
> Date: Wed, 27 Nov 2024 22:30:54 +0100
> Subject: [PATCH] gnu: Add scenefx.
>
> * gnu/packages/wm.scm (scenefx): New variable.
>
> Signed-off-by: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
> Change-Id: Ia91747cbec59226a83a020b5fedbfd99886c35df
> ---
>  gnu/packages/wm.scm | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
> index 921f9750378..2ab6f88cd5b 100644
> --- a/gnu/packages/wm.scm
> +++ b/gnu/packages/wm.scm
> @@ -76,6 +76,7 @@
>  ;;; Copyright © 2024 dan <i <at> dan.games>
>  ;;; Copyright © 2024 Wamm K. D. <jaft.r <at> outlook.com>
>  ;;; Copyright © 2024 Ashish SHUKLA <ashish.is <at> lostca.se>
> +;;; Copyright © 2024 Josep Bigorra <jjbigorra <at> gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -3969,3 +3970,32 @@ (define-public wf-config
>  configuration files of Wayifre.  It can set key and mouse bindings,
>  configure input, and customize Wayfire plugins.")
>      (license license:expat)))
> +
> +(define-public scenefx
> +  (package
> +    (name "scenefx")
> +    (version "0.1")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/wlrfx/scenefx")
> +                    (commit version)))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "1r7f8bprsn0mwlkmc8d14nr3iibljfyxypb4i06v66ghlngaw6dw"))))
> +    (build-system meson-build-system)
> +    (native-inputs (list pkg-config
> +                         ;; for wayland-scanner.
> +                         wayland))
> +    (inputs (list pixman
> +                  mesa
> +                  libxkbcommon
> +                  libdrm
> +                  wlroots-0.17))
> +    (home-page "https://github.com/wlrfx/scenefx")
> +    (synopsis "Drop-in replacement for the wlroots scene API")
> +    (description
> +     "A drop-in replacement for the wlroots scene API that allows wayland
> +compositors to render surfaces with eye-candy effects.")
> +    (license license:expat)))
>
> base-commit: c5421392081944d43db18fe04eafecec521f994a
> prerequisite-patch-id: 87446432571a7ef03b5b1c5a831298c21b1b28a8
> prerequisite-patch-id: fed79dd6ff68c92729413fc125b19314aa1bc3c4

pushed, closing.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.