GNU bug report logs - #74511
31.0.50; `dictionary-search-interface' overrides the user's customization of `dictionary-read-word-function'

Previous Next

Full log

View this message in rfc822 format

From: Eshel Yaron <me <at> eshelyaron.com>
To: Steven Allen <steven <at> stebalien.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 74511 <at> debbugs.gnu.org
Subject: bug#74511: 31.0.50; `dictionary-search-interface' overrides the user's customization of `dictionary-read-word-function'
Date: Mon, 25 Nov 2024 22:27:57 +0100

Steven Allen <steven <at> stebalien.com> writes:

> Eshel Yaron <me <at> eshelyaron.com> writes:
>
>>
>> The patch below tries to do both: 
>>
>> - it adds a few words to the docstring of dictionary-search-interface
>>   which explain that this option can only be meaningfully set after
>>   loading dictionary.el, and
>> - it avoids clobbering existing settings for the other options during
>>   initialization.  It still overrides existing settings for the other
>>   options if you set dictionary-search-interface after dictionary.el,
>>   because that's the intended behavior when customizing this option.
>>
>> WDYT?
>>
>
> Is adding the following to `dictionary-search-interface' not sufficient?
>
>     :initialize 'custom-initialize-changed
>
> That would apply the `dictionary-search-interface' setting if and only
> if specified by the user while still alowing the user to, e.g., use the
> customize interface.

Ah yes, seems even better than my patch since it also makes it possible
to set dictionary-search-interface before loading dictionary.el, thanks!

Eli, does this seem OK for the release branch?

diff --git a/lisp/net/dictionary.el b/lisp/net/dictionary.el
index 58c2e9771ba..42fb8c57b40 100644
--- a/lisp/net/dictionary.el
+++ b/lisp/net/dictionary.el
@@ -317,6 +317,7 @@ dictionary-search-interface
                       dictionary-read-dictionary-function)
                      vals))
          (set-default-toplevel-value symbol value))
+  :initialize #'custom-initialize-changed
   :version "30.1")
 
 (defface dictionary-word-definition-face

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.