GNU bug report logs - #74305
[PATCH 0/2] Improve piem package

Previous Next

Full log

Message #14 received at 74305 <at> debbugs.gnu.org (full text, mbox):

From: Noé Lopez <noe <at> xn--no-cja.eu>
To: 74305 <at> debbugs.gnu.org
Cc: Liam Hupfer <liam <at> hpfr.net>
Subject: Re: [PATCH 0/2] Improve piem package
Date: Thu, 14 Nov 2024 00:38:23 +0100

Hi,

Thanks for your patch,

Everything is great, you just forgot a dot at the end of your commit
messages and description :P You can check the git log for examples.

Can you send an updated patch?

Have a good day,
Noé Lopez


> * gnu/packages/emacs-xyz (emacs-piem): Build Info manual
> 
> Change-Id: Id3be957586e430f74330e35c6e39e08437668d0e
> ---
>  gnu/packages/emacs-xyz.scm | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 88e1ab89a9..7772a80192 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -9785,7 +9785,13 @@ (define-public emacs-piem
>                   (lambda* (#:key inputs #:allow-other-keys)
>                     (emacs-substitute-variables "piem-b4.el"
>                       ("piem-b4-b4-executable"
> -                      (search-input-file inputs "/bin/b4"))))))))
> +                      (search-input-file inputs "/bin/b4")))))
> +               (add-after 'install 'makeinfo
> +                 (lambda _
> +                   (invoke "makeinfo" "Documentation/piem.texi")
> +                   (install-file "piem.info"
> +                                 (string-append #$output "/share/info")))))))
> +    (native-inputs (list texinfo))
>      (inputs
>       (list b4
>             emacs-debbugs
> -- 
> 2.46.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.