GNU bug report logs - #74305
[PATCH 0/2] Improve piem package

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74305 in the body.
You can then email your comments to 74305 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Liam Hupfer <liam <at> hpfr.net>
To: guix-patches <at> gnu.org
Cc: Liam Hupfer <liam <at> hpfr.net>
Subject: [PATCH 0/2] Improve piem package
Date: Sun, 10 Nov 2024 20:13:00 -0600

Hi all, new contributor here. Please let me know if there are any issues
with commit message conventions or mail etiquette.

Liam Hupfer (2):
  gnu: emacs-piem: Build Info manual
  gnu: emacs-piem: Canonicalize home-page URL

 gnu/packages/emacs-xyz.scm | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)


base-commit: 9cdcfb52ace77fe3b497b21deb639a3027ff02f0
-- 
2.46.0

Message #8 received at 74305 <at> debbugs.gnu.org (full text, mbox):

From: Liam Hupfer <liam <at> hpfr.net>
To: 74305 <at> debbugs.gnu.org
Cc: Liam Hupfer <liam <at> hpfr.net>
Subject: [PATCH 2/2] gnu: emacs-piem: Canonicalize home-page URL
Date: Sun, 10 Nov 2024 20:52:42 -0600

guix lint warns about a permanent redirect.

* gnu/packages/emacs-xyz.scm (emacs-piem): Canonicalize home-page URL.

Change-Id: I8362436789a7e4736fc4572963a817b3532ca58a
---
 gnu/packages/emacs-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 7772a80192..ddd691faa3 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -9797,7 +9797,7 @@ (define-public emacs-piem
            emacs-debbugs
            emacs-elfeed
            emacs-notmuch))
-    (home-page "https://docs.kyleam.com/piem")
+    (home-page "https://docs.kyleam.com/piem/")
     (synopsis "Glue for working with public-inbox archives")
     (description "This package provides a collection of Emacs libraries for
 working with public-inbox archives.  As much of the hard work here is already
-- 
2.46.0

Message #11 received at 74305 <at> debbugs.gnu.org (full text, mbox):

From: Liam Hupfer <liam <at> hpfr.net>
To: 74305 <at> debbugs.gnu.org
Cc: Liam Hupfer <liam <at> hpfr.net>
Subject: [PATCH 1/2] gnu: emacs-piem: Build Info manual
Date: Sun, 10 Nov 2024 20:52:41 -0600

* gnu/packages/emacs-xyz (emacs-piem): Build Info manual

Change-Id: Id3be957586e430f74330e35c6e39e08437668d0e
---
 gnu/packages/emacs-xyz.scm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 88e1ab89a9..7772a80192 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -9785,7 +9785,13 @@ (define-public emacs-piem
                  (lambda* (#:key inputs #:allow-other-keys)
                    (emacs-substitute-variables "piem-b4.el"
                      ("piem-b4-b4-executable"
-                      (search-input-file inputs "/bin/b4"))))))))
+                      (search-input-file inputs "/bin/b4")))))
+               (add-after 'install 'makeinfo
+                 (lambda _
+                   (invoke "makeinfo" "Documentation/piem.texi")
+                   (install-file "piem.info"
+                                 (string-append #$output "/share/info")))))))
+    (native-inputs (list texinfo))
     (inputs
      (list b4
            emacs-debbugs
-- 
2.46.0

Message #14 received at 74305 <at> debbugs.gnu.org (full text, mbox):

From: Noé Lopez <noe <at> xn--no-cja.eu>
To: 74305 <at> debbugs.gnu.org
Cc: Liam Hupfer <liam <at> hpfr.net>
Subject: Re: [PATCH 0/2] Improve piem package
Date: Thu, 14 Nov 2024 00:38:23 +0100

Hi,

Thanks for your patch,

Everything is great, you just forgot a dot at the end of your commit
messages and description :P You can check the git log for examples.

Can you send an updated patch?

Have a good day,
Noé Lopez


> * gnu/packages/emacs-xyz (emacs-piem): Build Info manual
> 
> Change-Id: Id3be957586e430f74330e35c6e39e08437668d0e
> ---
>  gnu/packages/emacs-xyz.scm | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 88e1ab89a9..7772a80192 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -9785,7 +9785,13 @@ (define-public emacs-piem
>                   (lambda* (#:key inputs #:allow-other-keys)
>                     (emacs-substitute-variables "piem-b4.el"
>                       ("piem-b4-b4-executable"
> -                      (search-input-file inputs "/bin/b4"))))))))
> +                      (search-input-file inputs "/bin/b4")))))
> +               (add-after 'install 'makeinfo
> +                 (lambda _
> +                   (invoke "makeinfo" "Documentation/piem.texi")
> +                   (install-file "piem.info"
> +                                 (string-append #$output "/share/info")))))))
> +    (native-inputs (list texinfo))
>      (inputs
>       (list b4
>             emacs-debbugs
> -- 
> 2.46.0

Message #17 received at 74305 <at> debbugs.gnu.org (full text, mbox):

From: Liam Hupfer <liam <at> hpfr.net>
To: 74305 <at> debbugs.gnu.org
Cc: Liam Hupfer <liam <at> hpfr.net>
Subject: [PATCH v2 1/2] gnu: emacs-piem: Build Info manual.
Date: Thu, 14 Nov 2024 23:54:21 -0600

* gnu/packages/emacs-xyz (emacs-piem): Build Info manual.

Change-Id: Id3be957586e430f74330e35c6e39e08437668d0e
---
 gnu/packages/emacs-xyz.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b3517b7bd9..39f43824b8 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -147,6 +147,7 @@
 ;;; Copyright © 2024 Artyom V. Poptsov <poptsov.artyom <at> gmail.com>
 ;;; Copyright © 2024 Spencer King <spencer.king <at> nursiapress.com>
 ;;; Copyright © 2024 emma thompson <bigbookofbug <at> proton.me>
+;;; Copyright © 2024 Liam Hupfer <liam <at> hpfr.net>
 
 ;;;
 ;;; This file is part of GNU Guix.
@@ -9785,7 +9786,13 @@ (define-public emacs-piem
                  (lambda* (#:key inputs #:allow-other-keys)
                    (emacs-substitute-variables "piem-b4.el"
                      ("piem-b4-b4-executable"
-                      (search-input-file inputs "/bin/b4"))))))))
+                      (search-input-file inputs "/bin/b4")))))
+               (add-after 'install 'makeinfo
+                 (lambda _
+                   (invoke "makeinfo" "Documentation/piem.texi")
+                   (install-file "piem.info"
+                                 (string-append #$output "/share/info")))))))
+    (native-inputs (list texinfo))
     (inputs
      (list b4
            emacs-debbugs
-- 
2.46.0

Message #20 received at 74305 <at> debbugs.gnu.org (full text, mbox):

From: Liam Hupfer <liam <at> hpfr.net>
To: 74305 <at> debbugs.gnu.org
Cc: Liam Hupfer <liam <at> hpfr.net>
Subject: [PATCH v2 0/2] Improve piem package
Date: Thu, 14 Nov 2024 23:54:20 -0600

Thanks Noé, I fixed the commit message punctuation and added a copyright
notice now.

Liam Hupfer (2):
  gnu: emacs-piem: Build Info manual.
  gnu: emacs-piem: Canonicalize home-page URL.

 gnu/packages/emacs-xyz.scm | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)


base-commit: 1592f1ac3b39ba7217d3e0d43f589ead8818c449
-- 
2.46.0

Message #23 received at 74305 <at> debbugs.gnu.org (full text, mbox):

From: Liam Hupfer <liam <at> hpfr.net>
To: 74305 <at> debbugs.gnu.org
Cc: Liam Hupfer <liam <at> hpfr.net>
Subject: [PATCH v2 2/2] gnu: emacs-piem: Canonicalize home-page URL.
Date: Thu, 14 Nov 2024 23:54:22 -0600

guix lint warns about a permanent redirect.

* gnu/packages/emacs-xyz.scm (emacs-piem): Canonicalize home-page URL.

Change-Id: I8362436789a7e4736fc4572963a817b3532ca58a
---
 gnu/packages/emacs-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 39f43824b8..850c22863b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -9798,7 +9798,7 @@ (define-public emacs-piem
            emacs-debbugs
            emacs-elfeed
            emacs-notmuch))
-    (home-page "https://docs.kyleam.com/piem")
+    (home-page "https://docs.kyleam.com/piem/")
     (synopsis "Glue for working with public-inbox archives")
     (description "This package provides a collection of Emacs libraries for
 working with public-inbox archives.  As much of the hard work here is already
-- 
2.46.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.