GNU bug report logs - #74235
[PATCH] ; Remove 'nil' from some 'lua-ts-mode' options

Previous Next

Full log

Message #40 received at 74235-done <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 74235-done <at> debbugs.gnu.org
Subject: Re: bug#74235: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options
Date: Thu, 14 Nov 2024 21:54:26 -0600

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: john muhl <jm <at> pub.pink>
>> Cc: 74235 <at> debbugs.gnu.org
>> Date: Sun, 10 Nov 2024 08:48:39 -0600
>> 
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>> 
>> >> From: john muhl <jm <at> pub.pink>
>> >> Cc: 74235 <at> debbugs.gnu.org
>> >> Date: Sat, 09 Nov 2024 14:54:47 -0600
>> >> 
>> >> +  (if (or (not lua-ts-inferior-program)
>> >> +          (not (executable-find lua-ts-inferior-program)))
>> >> + (user-error "You must set `lua-ts-inferior-program' to use this
>> >> command")
>> >
>> > The text of user-error should say something about being unable to find
>> > the program, not just about the variable being nil, since you use
>> > executable-find.
>> >
>> > Otherwise, LGTM, thanks.
>> 
>> I guess the executable-find check is redundant anyway since
>> comint/process will tell you “Searching for program: No such file
>> or directory, luaz” if you get it wrong.
>
> Thanks, installed on the emacs-30 branch, and closing the bug.
>
> Btw, I noticed that you are marking with ";" the log entries of
> changes which should definitely appear in the produced ChangeLog.  Is
> this on purpose, or did you misunderstand the meaning of the
> semi-colon in the first line of the commit log messages?

Temporary (hopefully) confusion. I think I had NEWS entries on my
mind and conflated the the semicolon with not needing an entry
there. I should probably re-read CONTRIBUTING since it’s been
awhile and I don’t contribute often enough to have it all
ingrained yet.

Thanks for your patience.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.