GNU bug report logs - #74236
emacs-guix: guix-command-popup not displaying argument improvers

Previous Next

To reply to this bug, email your comments to 74236 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Howard <christopher <at> librehacker.com>
To: bug-guix <at> gnu.org
Subject: emacs-guix: guix-command-popup not displaying argument improvers
Date: Wed, 06 Nov 2024 14:51:49 -0900

Note that to even display the guix-command-popup, you have to either set guix-repl-use-server to nil, or apply the patch from bug#73462.

The magit popup code for the guix-command-popup (M-x guix c) appears to be broken so that it skips the popup menu where you would construct your command line argument. Instead, it assumes an empty argument, and jumps to the popup where you select whether you want to run the command in the REPL or from a shell.

This code is in guix-command.el, and uses the old magit-popup interface (now superceded by transient). Presumably either something has changed in magit-popup since the code was written (2015-2020) or some Emacs change has broken guix-command.el. I hope to investigate this further. My hope is that some minor fix can be made to guix-command.el rather than having to rewrite everything for transient.

One part I am fuzzy on is how to debug it as it is apparently not possible to run edebug-instrument-function on guix-command-popup, as guix-command-popup is a function generated by other code. If anybody has any advice concerning this, that would be helpful.

Testing this on GNU Emacs 30.0.92 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.41, cairo version 1.18.0) of 2024-10-29.

-- 
📛 Christopher Howard
🚀 gemini://gem.librehacker.com
🌐 http://gem.librehacker.com

בראשית ברא אלהים את השמים ואת הארץ

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Howard <christopher <at> librehacker.com>
To: 74236 <at> debbugs.gnu.org
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, guix-patches <at> gnu.org,
 Andrew Tropin <andrew <at> trop.in>
Subject: [bug#74236][PATCH] Tweaks command parsing regex to address debbugs
 bug#74236
Date: Thu, 07 Nov 2024 12:25:18 -0900

[0001-Tweaks-command-parsing-regex-to-address-debbugs-bug-.patch (text/x-patch, attachment)]

[Message part 2 (text/plain, inline)]

See also bug#73462 for a patch which ideally would be applied first, but is not strictly speaking a prerequisite.

-- 
Christopher Howard

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.