GNU bug report logs - #74235
[PATCH] ; Remove 'nil' from some 'lua-ts-mode' options

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#74235: closed ([PATCH] ; Remove 'nil' from some 'lua-ts-mode'
 options)
Date: Thu, 14 Nov 2024 08:27:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 14 Nov 2024 10:26:02 +0200
with message-id <8634jukyqt.fsf <at> gnu.org>
and subject line Re: bug#74235: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options
has caused the debbugs.gnu.org bug report #74235,
regarding [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
74235: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74235
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: john muhl <jm <at> pub.pink>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options
Date: Wed, 06 Nov 2024 15:19:52 -0600

Tags: patch

For some silly reason the lua-ts-{inferior,luacheck}-program
options ended up with an option for “None”. Obviously setting your
Lua interpreter or linter program to nil is not going to work.

Any chance it could make it into emacs-30?

Thanks.

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: john muhl <jm <at> pub.pink>
Cc: 74235-done <at> debbugs.gnu.org
Subject: Re: bug#74235: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options
Date: Thu, 14 Nov 2024 10:26:02 +0200

> From: john muhl <jm <at> pub.pink>
> Cc: 74235 <at> debbugs.gnu.org
> Date: Sun, 10 Nov 2024 08:48:39 -0600
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> From: john muhl <jm <at> pub.pink>
> >> Cc: 74235 <at> debbugs.gnu.org
> >> Date: Sat, 09 Nov 2024 14:54:47 -0600
> >> 
> >> +  (if (or (not lua-ts-inferior-program)
> >> +          (not (executable-find lua-ts-inferior-program)))
> >> +      (user-error "You must set `lua-ts-inferior-program' to use this command")
> >
> > The text of user-error should say something about being unable to find
> > the program, not just about the variable being nil, since you use
> > executable-find.
> >
> > Otherwise, LGTM, thanks.
> 
> I guess the executable-find check is redundant anyway since
> comint/process will tell you “Searching for program: No such file
> or directory, luaz” if you get it wrong.

Thanks, installed on the emacs-30 branch, and closing the bug.

Btw, I noticed that you are marking with ";" the log entries of
changes which should definitely appear in the produced ChangeLog.  Is
this on purpose, or did you misunderstand the meaning of the
semi-colon in the first line of the commit log messages?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.