GNU bug report logs - #74196
maint: assume proper behavior of tolower

Previous Next

Full log

View this message in rfc822 format

From: Simon Josefsson <simon <at> josefsson.org>
To: Collin Funk <collin.funk1 <at> gmail.com>
Cc: 74196 <at> debbugs.gnu.org
Subject: bug#74196: maint: assume proper behavior of tolower
Date: Tue, 05 Nov 2024 10:01:35 +0100

[Message part 1 (text/plain, inline)]

Collin Funk <collin.funk1 <at> gmail.com> writes:

> -#  define casemap(c) tolow(c) /* Force file names to lower case */

This is for MSDOS/OS2/WIN32/ATARI only as far as I can tell -- do we
know that tolower() works as expected on these architectures?  What
problem is caused by the current behaviour?  I think it would be nice to
establish that first.

> @@ -228,7 +228,7 @@ strlwr (char *s)
...
> -      *t = tolow ((unsigned char) *t);
> +      *t = tolower ((unsigned char) *t);

This changes strlwr(), it would be good to audit all usages of it to
understand impact of a change.

/Simon

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.