GNU bug report logs - #74196
maint: assume proper behavior of tolower

Previous Next

To reply to this bug, email your comments to 74196 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Collin Funk <collin.funk1 <at> gmail.com>
To: bug-gzip <at> gnu.org
Subject: maint: assume proper behavior of tolower
Date: Sun, 03 Nov 2024 15:47:22 -0800

[Message part 1 (text/plain, inline)]

Some pre-standard C implementations of tolower had undefined behavior if
the character passed to it was not an uppercase character.

This patch removes the isupper check before calling tolower since any
reasonable platform will behave correctly.

Collin

[0001-maint-assume-proper-behavior-of-tolower.patch (text/x-patch, attachment)]

Message #8 received at 74196 <at> debbugs.gnu.org (full text, mbox):

From: Simon Josefsson <simon <at> josefsson.org>
To: Collin Funk <collin.funk1 <at> gmail.com>
Cc: 74196 <at> debbugs.gnu.org
Subject: Re: bug#74196: maint: assume proper behavior of tolower
Date: Tue, 05 Nov 2024 10:01:35 +0100

[Message part 1 (text/plain, inline)]

Collin Funk <collin.funk1 <at> gmail.com> writes:

> -#  define casemap(c) tolow(c) /* Force file names to lower case */

This is for MSDOS/OS2/WIN32/ATARI only as far as I can tell -- do we
know that tolower() works as expected on these architectures?  What
problem is caused by the current behaviour?  I think it would be nice to
establish that first.

> @@ -228,7 +228,7 @@ strlwr (char *s)
...
> -      *t = tolow ((unsigned char) *t);
> +      *t = tolower ((unsigned char) *t);

This changes strlwr(), it would be good to audit all usages of it to
understand impact of a change.

/Simon

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 74196 <at> debbugs.gnu.org (full text, mbox):

From: Collin Funk <collin.funk1 <at> gmail.com>
To: Simon Josefsson <simon <at> josefsson.org>
Cc: 74196 <at> debbugs.gnu.org
Subject: Re: bug#74196: maint: assume proper behavior of tolower
Date: Mon, 11 Nov 2024 10:42:47 -0800

Hi Simon,

Simon Josefsson <simon <at> josefsson.org> writes:

> This is for MSDOS/OS2/WIN32/ATARI only as far as I can tell -- do we
> know that tolower() works as expected on these architectures?  What
> problem is caused by the current behaviour?  I think it would be nice to
> establish that first.

I doubt MSDOS, OS2, ATARI would be supported by Gnulib. I haven't used
them so I can't say for sure. But they are old.

> This changes strlwr(), it would be good to audit all usages of it to
> understand impact of a change.

Good point. It is only used in 'gzip_base_name' from util.c. It looks
like that is used in a few files to convert the input file name to the
archive file name. Probably needed for some proprietary systems,
although I'm not sure which ones.

Collin

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: bug-gzip <at> gnu.org
Subject: Re: bug#74196: maint: assume proper behavior of tolower
Date: Mon, 11 Nov 2024 14:34:03 -0800

On 2024-11-11 10:42, Collin Funk wrote:
> I doubt MSDOS, OS2, ATARI would be supported by Gnulib.

Not only are they not supported by Gnulib, I'm sure gzip hasn't worked 
on them for decades. We just haven't bothered to rip out all the 
supporting code.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.