GNU bug report logs - #74173
[PATCH] gnu: Add emacs-eslint-flymake.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74173 in the body.
You can then email your comments to 74173 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Javier Olaechea <pirata <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-eslint-flymake.
Date: Sat, 2 Nov 2024 05:34:56 +0000

[Message part 1 (text/plain, inline)]

Hi,

Attached is a patch to add the eslint-flymake package. It is a flymake
backend for ESLint.

Cheers

-- 
"I object to doing things that computers can do." — Olin Shivers

[Message part 2 (text/html, inline)]

[0001-gnu-Add-emacs-eslint-flymake.patch (text/x-patch, attachment)]

Message #8 received at 74173 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 74173 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add emacs-eslint-flymake.
Date: Sun, 03 Nov 2024 21:01:29 +0100

Hi Javier,

I just took a quick look at the package and haven't tried to build it
yet.  Shouldn't it hardcode the eslint binary and add eslint as an
input?

I guess this would be necessary since we would probably expect that such
a package should work without requiring the user to explicitely install
eslint in its profile.

-- 
Best regards,
Nicolas Graves

Message #11 received at 74173 <at> debbugs.gnu.org (full text, mbox):

From: Javier Olaechea <pirata <at> gmail.com>
To: 74173 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add emacs-eslint-flymake.
Date: Mon, 4 Nov 2024 04:59:41 +0000

[Message part 1 (text/plain, inline)]

> Shouldn't it hardcode the eslint binary and add eslint as an input?

I can see the argument for both cases. In favor of listing as a dependency
is that the minor mode can be enabled globally out of the box and it will
run successfully. I also checked other flymake packages included by GUIX,
https://packages.guix.gnu.org/search/?query=flymake, like proselint and
percritic and we _do_ include programs they depend on as a dependency. So
including eslint as dependency seems aligned with our practices.  If we end
up deciding to do this, should we include rubocop as a dependency of
emacs-flymake? The flymake package ships with a rubocop backend.

The argument against is that ESlint is a program one runs in the context of
developing software for a specific project. ESlint has multiple versions
with different defaults. And one always wants to run the same version of
ESLint that is specified by the package.json. As that is the version that
will be used by CI. Personally I use npx to ensure that the version of
ESLint being used is the project specific one w/o having to resort to
project specific configuration.

My personal preference would be to not include it, but I'm fine either way.
Let me know what you think.

A more practical consideration for not including ESLint as an input right
now is that we don't have a package for it! I can look into packaging
ESLint but I'd rather we block this patch until we package ESLint. It seems
RDE has a package for it.

Cheers

-- 
"I object to doing things that computers can do." — Olin Shivers

[Message part 2 (text/html, inline)]

Message #16 received at 74173-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Javier Olaechea <pirata <at> gmail.com>
Cc: 74173-done <at> debbugs.gnu.org
Subject: Re: [bug#74173] [PATCH] gnu: Add emacs-eslint-flymake.
Date: Fri, 03 Jan 2025 12:09:15 +0100

Hello,

Javier Olaechea <pirata <at> gmail.com> writes:

> Attached is a patch to add the eslint-flymake package. It is a flymake
> backend for ESLint.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.