GNU bug report logs - #74172
[PATCH 0/2] Update senpai to 0.3.0 and add delthas-tcell-v2.

Previous Next

Package: guix-patches;

Reported by: get-state <mazin <at> getstate.dev>

Date: Sat, 2 Nov 2024 05:17:02 UTC

Severity: normal

Tags: easy, patch

Done: Christopher Baines <mail <at> cbaines.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74172 in the body.
You can then email your comments to 74172 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#74172; Package guix-patches. (Sat, 02 Nov 2024 05:17:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to get-state <mazin <at> getstate.dev>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 02 Nov 2024 05:17:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: get-state <mazin <at> getstate.dev>
To: guix-patches <at> gnu.org
Cc: get-state <mazin <at> getstate.dev>
Subject: [PATCH 0/2] Update senpai to 0.3.0 and add delthas-tcell-v2.
Date: Fri,  1 Nov 2024 22:58:16 +0300
get-state (2):
  gnu: go-github-com-delthas-tcell-v2: New variable.
  gnu: senpai: Update to 0.3.0.

 gnu/packages/golang.scm    | 28 ++++++++++++++++++++++++++++
 gnu/packages/messaging.scm |  9 +++++----
 2 files changed, 33 insertions(+), 4 deletions(-)


base-commit: 870b7d69b4b06d01cdf6bfca71bcc161c0b832bf
-- 
2.46.0





Information forwarded to guix-patches <at> gnu.org:
bug#74172; Package guix-patches. (Sat, 02 Nov 2024 07:42:02 GMT) Full text and rfc822 format available.

Message #8 received at 74172 <at> debbugs.gnu.org (full text, mbox):

From: Mazin AlHaddad <mazin <at> getstate.dev>
To: 74172 <at> debbugs.gnu.org
Cc: Mazin Alhaddad <mazin <at> getstate.dev>
Subject: [PATCH 1/2] gnu: go-github-com-delthas-tcell-v2: New variable.
Date: Sat,  2 Nov 2024 10:40:28 +0300
From: Mazin Alhaddad <mazin <at> getstate.dev>

* gnu/packages/golang.scm (go-github-com-delthas-tcell-v2): New variable.

Change-Id: Ifc15544e2e78215a4f6cdc36cd316dd10fa0071e
---
 gnu/packages/golang.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 00dde61f2c..bdfee798bf 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -5135,6 +5135,34 @@ (define-public go-github-com-gdamore-tcell-v2
        (modify-inputs (package-inputs go-github-com-gdamore-tcell)
          (prepend go-golang-org-x-term go-golang-org-x-sys)))))
 
+(define-public go-github-com-delthas-tcell-v2
+  (package
+    (inherit go-github-com-gdamore-tcell)
+    (name "go-github-com-delthas-tcell")
+    (version "2.4.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/delthas/tcell")
+             (commit "837a7d7")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "05zr73q38dawl7hr6g7v4pkyv6mqr0zp2l9qsgn7xmf1p9q4bn7j"))))
+    (arguments
+     (list
+      #:import-path "github.com/gdamore/tcell/v2"
+      #:phases #~(modify-phases %standard-phases
+                   (add-before 'reset-gzip-timestamps 'make-files-writable
+                     (lambda _
+                       ;; Make sure .gz files are writable so that the
+                       ;; 'reset-gzip-timestamps' phase can do its work.
+                       (for-each make-file-writable
+                                 (find-files #$output "\\.gz$")))))))
+    (propagated-inputs (modify-inputs (package-inputs
+                                       go-github-com-gdamore-tcell)
+                         (prepend go-golang-org-x-term go-golang-org-x-sys)))))
+
 (define-public go-git-sr-ht-rockorager-tcell-term
   (package
     (name "go-git-sr-ht-rockorager-tcell-term")
-- 
2.46.0





Information forwarded to guix-patches <at> gnu.org:
bug#74172; Package guix-patches. (Sat, 02 Nov 2024 07:42:02 GMT) Full text and rfc822 format available.

Message #11 received at 74172 <at> debbugs.gnu.org (full text, mbox):

From: Mazin AlHaddad <mazin <at> getstate.dev>
To: 74172 <at> debbugs.gnu.org
Cc: Mazin Alhaddad <mazin <at> getstate.dev>
Subject: [PATCH 2/2] gnu: senpai: Update to 0.3.0.
Date: Sat,  2 Nov 2024 10:40:29 +0300
From: Mazin Alhaddad <mazin <at> getstate.dev>

* gnu/packages/messaging.scm (senpai): Update to 0.3.0.
[phases]: Switch to `make doc` in build-doc phase.
[native-inputs]: Add `which`.

Change-Id: I40d5cae27eb716da1ed6d9dddc1e19f33ae683b6
---
 gnu/packages/messaging.scm | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index c482cd469e..72b68d9495 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -3595,7 +3595,7 @@ (define-public pn
 (define-public senpai
   (package
     (name "senpai")
-    (version "0.2.0")
+    (version "0.3.0")
     (source
      (origin
        (method git-fetch)
@@ -3605,7 +3605,7 @@ (define-public senpai
          (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1qw955i5f3jr42h4afr23v7wq616bcsyq68if75qdw8j1yibnpmb"))))
+        (base32 "0l43qfjr0ggpv1hkyyfxp3j6acrbbrl8n6qxlh91gyb2jan03683"))))
     (build-system go-build-system)
     (arguments
       (list #:import-path "git.sr.ht/~taiite/senpai/cmd/senpai"
@@ -3615,7 +3615,7 @@ (define-public senpai
             #~(modify-phases %standard-phases
                 (add-after 'build 'build-doc
                   (lambda* (#:key unpack-path #:allow-other-keys)
-                    (invoke "make" "doc/senpai.1" "doc/senpai.5"
+                    (invoke "make" "doc"
                             "-C" (string-append "src/" unpack-path))))
                 (add-after 'install 'install-doc
                   (lambda* (#:key unpack-path #:allow-other-keys)
@@ -3632,12 +3632,13 @@ (define-public senpai
     (native-inputs (list go-git-sr-ht-emersion-go-scfg
                          go-github-com-delthas-go-libnp
                          go-github-com-delthas-go-localeinfo
-                         go-github-com-gdamore-tcell-v2
+                         go-github-com-delthas-tcell-v2
                          go-github-com-mattn-go-runewidth
                          go-golang-org-x-net
                          go-golang-org-x-term
                          go-golang-org-x-time
                          go-mvdan-cc-xurls
+                         which
                          scdoc))
     (home-page "https://sr.ht/~delthas/senpai")
     (synopsis "Modern terminal IRC client")
-- 
2.46.0





Added tag(s) easy. Request was from Nicolas Graves <ngraves <at> ngraves.fr> to control <at> debbugs.gnu.org. (Sun, 03 Nov 2024 20:09:02 GMT) Full text and rfc822 format available.

Reply sent to Christopher Baines <mail <at> cbaines.net>:
You have taken responsibility. (Fri, 22 Nov 2024 22:01:03 GMT) Full text and rfc822 format available.

Notification sent to get-state <mazin <at> getstate.dev>:
bug acknowledged by developer. (Fri, 22 Nov 2024 22:01:03 GMT) Full text and rfc822 format available.

Message #18 received at 74172-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: get-state <mazin <at> getstate.dev>
Cc: 74172-done <at> debbugs.gnu.org
Subject: Re: [bug#74172] [PATCH 0/2] Update senpai to 0.3.0 and add
 delthas-tcell-v2.
Date: Fri, 22 Nov 2024 21:59:54 +0000
[Message part 1 (text/plain, inline)]
get-state <mazin <at> getstate.dev> writes:

> get-state (2):
>   gnu: go-github-com-delthas-tcell-v2: New variable.
>   gnu: senpai: Update to 0.3.0.
>
>  gnu/packages/golang.scm    | 28 ++++++++++++++++++++++++++++
>  gnu/packages/messaging.scm |  9 +++++----
>  2 files changed, 33 insertions(+), 4 deletions(-)
>
>
> base-commit: 870b7d69b4b06d01cdf6bfca71bcc161c0b832bf

Thanks for the patches, obviously senpai using the fork of tcell isn't
ideal so I've made the fork package hidden and removed some unneeded
fields.

I've pushed the patches to master as
c2a80ba78c979d2df2434fed0b9e55a29102f5c2.

Chris
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 21 Dec 2024 12:24:11 GMT) Full text and rfc822 format available.

This bug report was last modified 258 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.