GNU bug report logs - #74166
[PATCH] Fix tmm "previous menu" shortcut

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Subject: bug#74166: closed (Re: bug#74166: [PATCH] Fix tmm "previous menu"
 shortcut)
Date: Sat, 09 Nov 2024 10:36:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#74166: [PATCH] Fix tmm "previous menu" shortcut

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 74166 <at> debbugs.gnu.org.

-- 
74166: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74166
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: 74166-done <at> debbugs.gnu.org, juri <at> linkov.net
Subject: Re: bug#74166: [PATCH] Fix tmm "previous menu" shortcut
Date: Sat, 09 Nov 2024 12:34:58 +0200

> Cc: 74166 <at> debbugs.gnu.org
> Date: Sat, 02 Nov 2024 19:43:33 +0100
> From:  Manuel Giraud via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Juri Linkov <juri <at> linkov.net> writes:
> 
> >> +(defun tmm-clear-self-insert-and-exit ()
> >> +  "Clear the minibuffer content before self insert and exit."
> >> +  (interactive)
> >> +  (delete-region (minibuffer-prompt-end) (point-max))
> >> +  (self-insert-and-exit))
> >
> > There is a special function 'delete-minibuffer-contents'
> > like is used e.g. in 'read-char-from-minibuffer-insert-char'
> > and 'y-or-n-p-insert-y'.
> 
> Thanks.  Here is a new version that uses this.

Thanks, installed on the master branch, and closing the bug.

[Message part 3 (message/rfc822, inline)]

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix tmm "previous menu" shortcut
Date: Fri, 01 Nov 2024 19:36:00 +0100

[Message part 4 (text/plain, inline)]

Tags: patch

Hi,

The following patch fixes the "previous menu" shortcut in tmm-menubar
when one has already used Up/Down keys into a submenu.

How to reproduce the bug:
    - M-x tmm-menubar
    - t    ;; for the Tools menu
    - Down ;; to circulate to the first entry
    - ^    ;; quits tmm but should go back to toplevel instead

While here, explain a "Why?" comment.

In GNU Emacs 31.0.50 (build 86, x86_64-unknown-openbsd7.6, X toolkit) of
 2024-11-01 built on computer
Repository revision: ffda8dfe847094bd8488059be2f96270fe298fa5
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101013
System Description: OpenBSD computer 7.6 GENERIC.MP#394 amd64

Configured using:
 'configure CC=egcc CPPFLAGS=-I/usr/local/include
 LDFLAGS=-L/usr/local/lib MAKEINFO=gmakeinfo --prefix=/home/manuel/emacs
 --bindir=/home/manuel/bin --with-x-toolkit=lucid
 --with-toolkit-scroll-bars=no --without-cairo
 --without-compress-install'

[0001-Fix-tmm-previous-menu-shortcut.patch (text/patch, attachment)]

[Message part 6 (text/plain, inline)]

-- 
Manuel Giraud

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.