GNU bug report logs - #74166
[PATCH] Fix tmm "previous menu" shortcut

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74166 in the body.
You can then email your comments to 74166 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix tmm "previous menu" shortcut
Date: Fri, 01 Nov 2024 19:36:00 +0100

[Message part 1 (text/plain, inline)]

Tags: patch

Hi,

The following patch fixes the "previous menu" shortcut in tmm-menubar
when one has already used Up/Down keys into a submenu.

How to reproduce the bug:
    - M-x tmm-menubar
    - t    ;; for the Tools menu
    - Down ;; to circulate to the first entry
    - ^    ;; quits tmm but should go back to toplevel instead

While here, explain a "Why?" comment.

In GNU Emacs 31.0.50 (build 86, x86_64-unknown-openbsd7.6, X toolkit) of
 2024-11-01 built on computer
Repository revision: ffda8dfe847094bd8488059be2f96270fe298fa5
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101013
System Description: OpenBSD computer 7.6 GENERIC.MP#394 amd64

Configured using:
 'configure CC=egcc CPPFLAGS=-I/usr/local/include
 LDFLAGS=-L/usr/local/lib MAKEINFO=gmakeinfo --prefix=/home/manuel/emacs
 --bindir=/home/manuel/bin --with-x-toolkit=lucid
 --with-toolkit-scroll-bars=no --without-cairo
 --without-compress-install'

[0001-Fix-tmm-previous-menu-shortcut.patch (text/patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Manuel Giraud

Message #8 received at 74166 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: 74166 <at> debbugs.gnu.org
Subject: Re: bug#74166: [PATCH] Fix tmm "previous menu" shortcut
Date: Sat, 02 Nov 2024 19:10:10 +0200

> +(defun tmm-clear-self-insert-and-exit ()
> +  "Clear the minibuffer content before self insert and exit."
> +  (interactive)
> +  (delete-region (minibuffer-prompt-end) (point-max))
> +  (self-insert-and-exit))

There is a special function 'delete-minibuffer-contents'
like is used e.g. in 'read-char-from-minibuffer-insert-char'
and 'y-or-n-p-insert-y'.

Message #11 received at 74166 <at> debbugs.gnu.org (full text, mbox):

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: Juri Linkov <juri <at> linkov.net>
Cc: 74166 <at> debbugs.gnu.org
Subject: Re: bug#74166: [PATCH] Fix tmm "previous menu" shortcut
Date: Sat, 02 Nov 2024 19:43:33 +0100

[Message part 1 (text/plain, inline)]

Juri Linkov <juri <at> linkov.net> writes:

>> +(defun tmm-clear-self-insert-and-exit ()
>> +  "Clear the minibuffer content before self insert and exit."
>> +  (interactive)
>> +  (delete-region (minibuffer-prompt-end) (point-max))
>> +  (self-insert-and-exit))
>
> There is a special function 'delete-minibuffer-contents'
> like is used e.g. in 'read-char-from-minibuffer-insert-char'
> and 'y-or-n-p-insert-y'.

Thanks.  Here is a new version that uses this.

[0001-Fix-tmm-previous-menu-shortcut.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Manuel Giraud

Message #16 received at 74166-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: 74166-done <at> debbugs.gnu.org, juri <at> linkov.net
Subject: Re: bug#74166: [PATCH] Fix tmm "previous menu" shortcut
Date: Sat, 09 Nov 2024 12:34:58 +0200

> Cc: 74166 <at> debbugs.gnu.org
> Date: Sat, 02 Nov 2024 19:43:33 +0100
> From:  Manuel Giraud via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Juri Linkov <juri <at> linkov.net> writes:
> 
> >> +(defun tmm-clear-self-insert-and-exit ()
> >> +  "Clear the minibuffer content before self insert and exit."
> >> +  (interactive)
> >> +  (delete-region (minibuffer-prompt-end) (point-max))
> >> +  (self-insert-and-exit))
> >
> > There is a special function 'delete-minibuffer-contents'
> > like is used e.g. in 'read-char-from-minibuffer-insert-char'
> > and 'y-or-n-p-insert-y'.
> 
> Thanks.  Here is a new version that uses this.

Thanks, installed on the master branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.