GNU bug report logs - #74149
[PATCH] Remove undefined variable from c-ts-common-comment-indent-new-line

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#74149: closed ([PATCH] Remove undefined variable from
 c-ts-common-comment-indent-new-line)
Date: Fri, 01 Nov 2024 01:21:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 31 Oct 2024 18:19:48 -0700
with message-id <CADwFkmm_5RjTNsOTWhd62S-AUr6x9Lm6geFyNWOVPwycj-3jog <at> mail.gmail.com>
and subject line Re: bug#74149: [PATCH] Remove undefined variable from c-ts-common-comment-indent-new-line
has caused the debbugs.gnu.org bug report #74149,
regarding [PATCH] Remove undefined variable from c-ts-common-comment-indent-new-line
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
74149: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74149
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Steven Allen <steven <at> stebalien.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Remove undefined variable from
 c-ts-common-comment-indent-new-line
Date: Thu, 31 Oct 2024 16:27:55 -0700

[Message part 3 (text/plain, inline)]

Remove reference to allow-auto-fill from c-ts-common. This variable came
from code copied from c-indent-new-comment-line. It's a parameter meant
to be used by c-context-line-break, not a global variable.

[0001-Remove-undefined-variable-from-c-ts-common-comment-i.patch (text/x-patch, inline)]

From 5c7a5c86a9b2f6f09ac58cea15c51382540867a3 Mon Sep 17 00:00:00 2001
From: Steven Allen <steven <at> stebalien.com>
Date: Thu, 31 Oct 2024 16:19:37 -0700
Subject: [PATCH] Remove undefined variable from
 c-ts-common-comment-indent-new-line

This variable came from code copied from c-indent-new-comment-line. It's
a parameter meant to be used by c-context-line-break, not a global variable.

* lisp/progmodes/c-ts-common.el (c-ts-common-comment-indent-new-line):
remove reference undefined variable.
---
 lisp/progmodes/c-ts-common.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/progmodes/c-ts-common.el b/lisp/progmodes/c-ts-common.el
index 5c7909ae858..cf55ddea8f7 100644
--- a/lisp/progmodes/c-ts-common.el
+++ b/lisp/progmodes/c-ts-common.el
@@ -336,7 +336,7 @@ c-ts-common-comment-indent-new-line
 	   (delete-horizontal-space)
 	   (if soft
 	       (insert-and-inherit ?\n)
-	     (newline (if allow-auto-fill nil 1))))))
+	     (newline 1)))))
     (cond
      ;; Line starts with //, or ///, or ////...
      ;; Or //! (used in rust).
-- 
2.47.0

[Message part 5 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Steven Allen <steven <at> stebalien.com>, 74149-done <at> debbugs.gnu.org
Subject: Re: bug#74149: [PATCH] Remove undefined variable from
 c-ts-common-comment-indent-new-line
Date: Thu, 31 Oct 2024 18:19:48 -0700

Steven Allen via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs <at> gnu.org> writes:

> Remove reference to allow-auto-fill from c-ts-common. This variable came
> from code copied from c-indent-new-comment-line. It's a parameter meant
> to be used by c-context-line-break, not a global variable.

Thanks, installed on master (commit 9ff155183ca).  Closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.