GNU bug report logs - #74149
[PATCH] Remove undefined variable from c-ts-common-comment-indent-new-line

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74149 in the body.
You can then email your comments to 74149 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Steven Allen <steven <at> stebalien.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Remove undefined variable from
 c-ts-common-comment-indent-new-line
Date: Thu, 31 Oct 2024 16:27:55 -0700

[Message part 1 (text/plain, inline)]

Remove reference to allow-auto-fill from c-ts-common. This variable came
from code copied from c-indent-new-comment-line. It's a parameter meant
to be used by c-context-line-break, not a global variable.

[0001-Remove-undefined-variable-from-c-ts-common-comment-i.patch (text/x-patch, inline)]

From 5c7a5c86a9b2f6f09ac58cea15c51382540867a3 Mon Sep 17 00:00:00 2001
From: Steven Allen <steven <at> stebalien.com>
Date: Thu, 31 Oct 2024 16:19:37 -0700
Subject: [PATCH] Remove undefined variable from
 c-ts-common-comment-indent-new-line

This variable came from code copied from c-indent-new-comment-line. It's
a parameter meant to be used by c-context-line-break, not a global variable.

* lisp/progmodes/c-ts-common.el (c-ts-common-comment-indent-new-line):
remove reference undefined variable.
---
 lisp/progmodes/c-ts-common.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/progmodes/c-ts-common.el b/lisp/progmodes/c-ts-common.el
index 5c7909ae858..cf55ddea8f7 100644
--- a/lisp/progmodes/c-ts-common.el
+++ b/lisp/progmodes/c-ts-common.el
@@ -336,7 +336,7 @@ c-ts-common-comment-indent-new-line
 	   (delete-horizontal-space)
 	   (if soft
 	       (insert-and-inherit ?\n)
-	     (newline (if allow-auto-fill nil 1))))))
+	     (newline 1)))))
     (cond
      ;; Line starts with //, or ///, or ////...
      ;; Or //! (used in rust).
-- 
2.47.0

Message #10 received at 74149-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Steven Allen <steven <at> stebalien.com>, 74149-done <at> debbugs.gnu.org
Subject: Re: bug#74149: [PATCH] Remove undefined variable from
 c-ts-common-comment-indent-new-line
Date: Thu, 31 Oct 2024 18:19:48 -0700

Steven Allen via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs <at> gnu.org> writes:

> Remove reference to allow-auto-fill from c-ts-common. This variable came
> from code copied from c-indent-new-comment-line. It's a parameter meant
> to be used by c-context-line-break, not a global variable.

Thanks, installed on master (commit 9ff155183ca).  Closing.

Message #13 received at 74149-done <at> debbugs.gnu.org (full text, mbox):

From: Steven Allen <steven <at> stebalien.com>
To: Stefan Kangas <stefankangas <at> gmail.com>, 74149-done <at> debbugs.gnu.org
Subject: Re: bug#74149: [PATCH] Remove undefined variable from
 c-ts-common-comment-indent-new-line
Date: Thu, 31 Oct 2024 19:16:10 -0700

Stefan Kangas <stefankangas <at> gmail.com> writes:
>
> Thanks, installed on master (commit 9ff155183ca).  Closing.

Thanks!

Message #16 received at 74149-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 74149-done <at> debbugs.gnu.org, steven <at> stebalien.com
Subject: Re: bug#74149: [PATCH] Remove undefined variable from
 c-ts-common-comment-indent-new-line
Date: Fri, 01 Nov 2024 09:19:52 +0200

> Resent-To: bug-gnu-emacs <at> gnu.org
> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Thu, 31 Oct 2024 18:19:48 -0700
> 
> Steven Allen via "Bug reports for GNU Emacs, the Swiss army knife of
> text editors" <bug-gnu-emacs <at> gnu.org> writes:
> 
> > Remove reference to allow-auto-fill from c-ts-common. This variable came
> > from code copied from c-indent-new-comment-line. It's a parameter meant
> > to be used by c-context-line-break, not a global variable.
> 
> Thanks, installed on master (commit 9ff155183ca).  Closing.

This should not have been installed on master, because this problem
was already fixed on the release branch, and the fix will be merged to
master soon enough.

So I have reverted this fix on master.

Message #19 received at 74149-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 74149-done <at> debbugs.gnu.org, steven <at> stebalien.com
Subject: Re: bug#74149: [PATCH] Remove undefined variable from
 c-ts-common-comment-indent-new-line
Date: Fri, 1 Nov 2024 04:48:24 -0700

Eli Zaretskii <eliz <at> gnu.org> writes:

> This should not have been installed on master, because this problem
> was already fixed on the release branch, and the fix will be merged to
> master soon enough.
>
> So I have reverted this fix on master.

OK, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.