GNU bug report logs - #74147
[PATCH] gnu: tree-sitter: Update to 0.24.3.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74147 in the body.
You can then email your comments to 74147 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Doğan Çeçen <sepeth <at> fastmail.com>
To: guix-patches <at> gnu.org
Cc: Doğan Çeçen <sepeth <at> fastmail.com>
Subject: [PATCH] gnu: tree-sitter: Update to 0.24.3.
Date: Fri,  1 Nov 2024 00:02:30 +0200

This is needed to update neovim to a newer version.

Doğan Çeçen (1):
  gnu: tree-sitter: Update to 0.24.3.

 gnu/packages/tree-sitter.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)


base-commit: 6e50b0c56a8cc767bd3acb26638f78c450bde718
prerequisite-patch-id: 92d7009719a2df665b401eb25ee08f8d276be4bb
prerequisite-patch-id: 20902e145fdee43b599da928d596390abaa69805
-- 
2.46.0

Message #8 received at 74147 <at> debbugs.gnu.org (full text, mbox):

From: Noé Lopez <noe <at> xn--no-cja.eu>
To: 74147 <at> debbugs.gnu.org
Subject: [PATCH] gnu: tree-sitter: Update to 0.24.3.
Date: Fri, 01 Nov 2024 23:35:24 +0100

Hi Doğan,

Thank you for your patch, here are a few suggestions:

>               (uri (git-reference
>                     (url "https://github.com/tree-sitter/tree-sitter")
>-                    (commit "0e4ff0bb27edf37b76fc7d35aa768b02cf4392ad")))
>+                    (commit "v0.24.3")))
>               (file-name (git-file-name name version))
>               (sha256

You can use “string-append” to avoid repeating the version:
(commit (string-append "v" commit))

As a result of updating tree-sitter, the ”tree-sitter-cli” package has
stopped building for me, it is recommended that you check that
dependencies of tree-sitter don’t fail to build as a result of the
update, see “info (guix) Submitting Patches” step 9.

Can you send an updated patch?

Thanks for your work,
Noé Lopez

Disclaimer: I am not a guix committer, just a random person trying to help.

Message #17 received at 74147-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 74147-done <at> debbugs.gnu.org
Subject: Close
Date: Wed, 27 Nov 2024 13:10:46 +0100

Closing this bug, since 71748 contains the v2.

Thanks, Noé, for the review!

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.