GNU bug report logs - #7409
24.0.50; (server-force-stop) starts server process

Previous Next

Package: emacs;

Reported by: Ulrich Mueller <ulm <at> gentoo.org>

Date: Mon, 15 Nov 2010 21:40:02 UTC

Severity: normal

Merged with 7423

Found in version 24.0.50

Done: Chong Yidong <cyd <at> stupidchicken.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 7409 in the body.
You can then email your comments to 7409 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#7409; Package emacs. (Mon, 15 Nov 2010 21:40:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Ulrich Mueller <ulm <at> gentoo.org>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 15 Nov 2010 21:40:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ulrich Mueller <ulm <at> gentoo.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; (server-force-stop) starts server process
Date: Mon, 15 Nov 2010 22:44:09 +0100

Recently added function server-force-stop (in lisp/server.el) doesn't
always stop the server, but starts it if no server process is running.

The behaviour can be reproduced as follows (commands in Lisp
interaction buffer):

   (require 'server)
   server

   server-process
   nil

   (server-force-stop)
   nil

   server-process
   #<process server>

Included below is a trivial patch that should fix it.

Ulrich


2010-11-15  Ulrich Mueller  <ulm <at> gentoo.org>

	* server.el (server-force-stop): Call server-start with first
	argument set to t.

--- lisp/server.el~
+++ lisp/server.el
@@ -609,7 +609,7 @@
 (defun server-force-stop ()
   "Kill all connections to the current server.
 This function is meant to be called from `kill-emacs-hook'."
-  (server-start nil t))
+  (server-start t t))
 
 ;;;###autoload
 (defun server-force-delete (&optional name)
Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#7409; Package emacs. (Tue, 16 Nov 2010 20:05:02 GMT) Full text and rfc822 format available.

Message #8 received at 7409 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Ulrich Mueller <ulm <at> gentoo.org>
Cc: 7409 <at> debbugs.gnu.org
Subject: Re: bug#7409: 24.0.50; (server-force-stop) starts server process
Date: Tue, 16 Nov 2010 15:09:49 -0500

Ulrich Mueller <ulm <at> gentoo.org> writes:

> Recently added function server-force-stop (in lisp/server.el) doesn't
> always stop the server, but starts it if no server process is running.
>
> Included below is a trivial patch that should fix it.

Committed, thanks.
bug closed, send any further explanations to Ulrich Mueller <ulm <at> gentoo.org> Request was from Chong Yidong <cyd <at> stupidchicken.com> to control <at> debbugs.gnu.org. (Tue, 16 Nov 2010 20:06:02 GMT) Full text and rfc822 format available.
Forcibly Merged 7409 7423. Request was from Chong Yidong <cyd <at> stupidchicken.com> to control <at> debbugs.gnu.org. (Wed, 17 Nov 2010 15:47:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 16 Dec 2010 12:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 14 years and 189 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.