GNU bug report logs - #74058
[PATCH 0/2] [important] Set postgresql default value to #f and warn users.

Previous Next

Package: guix-patches;

Reported by: Nicolas Graves <ngraves <at> ngraves.fr>

Date: Mon, 28 Oct 2024 11:13:02 UTC

Severity: normal

Tags: patch

Done: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 74058 <at> debbugs.gnu.org
Subject: [bug#74058] [PATCH v2 1/2] gnu: postgresql-configuration: Set default postgresql to *no*.
Date: Tue, 12 Nov 2024 10:51:40 +0100

On 2024-11-12 10:03, Ludovic Courtès wrote:

>
> I think we misunderstood each other; when I wrote:

Big indeed ;)

>> How about having *no* default value in that case?
>
> I suggested removing the (default …) bit altogether, as in:
>
>   (define-record-type* <postgresql-configuration>
>     postgresql-configuration make-postgresql-configuration
>     postgresql-configuration?
>     (postgresql postgresql-configuration-postgresql)  ;no default value
>     …)
>
> That way, users get a syntax error (at macro-expansion time) if they
> omit the ‘postgresql’ field.
>
> Does that make sense?

Yep, will resend a version.

-- 
Best regards,
Nicolas Graves
This bug report was last modified 264 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.