GNU bug report logs - #74057
[PATCH] gnu: Add python-green.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74057 in the body.
You can then email your comments to 74057 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Wiktor Żelazny <wz <at> freeshell.de>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add python-green.
Date: Mon, 28 Oct 2024 11:31:52 +0100

* gnu/packages/python-check.scm (python-green): New variable.

Change-Id: I554e8a635ff51413c79e3834fc1b88b34bbda84b
---
 gnu/packages/python-check.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/python-check.scm b/gnu/packages/python-check.scm
index efd192ad2c..6cbb7e26e7 100644
--- a/gnu/packages/python-check.scm
+++ b/gnu/packages/python-check.scm
@@ -3001,3 +3001,27 @@ (define-public python-vulture
 dead code.  Also, code that is only called implicitly may be reported as
 unused.")
     (license license:expat)))
+
+(define-public python-green
+  (package
+    (name "python-green")
+    (version "4.0.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "green" version))
+       (sha256
+        (base32 "1cd62nbn5dvlpnsyplp6cb24wd230san8dpm6pnl99n2kwzpq1m4"))))
+    (build-system pyproject-build-system)
+    ;; python-coverage both in requirements.txt and requirements-dev.txt
+    (propagated-inputs (list python-colorama python-coverage python-lxml
+                             python-unidecode))
+    (native-inputs (list python-black python-django python-mypy
+                         python-testtools))
+    (home-page "https://github.com/CleanCut/green")
+    (synopsis "Clean, colorful, fast python test runner")
+    (description
+     "@code{green} is a python test runner which in addition to
+being clean, colorful and fast describes itself as powerful, traditional,
+descriptive, convenient, thorough, embedded, modern, portable and living.")
+    (license license:expat)))

base-commit: 4a46758aee863cc31815865cdac4c16fb6a0a879
-- 
2.46.0

Message #10 received at 74057 <at> debbugs.gnu.org (full text, mbox):

From: get-state <mazin <at> getstate.dev>
To: 74057 <at> debuggs.gnu.org,
	74057 <at> debbugs.gnu.org
Cc: get-state <mazin <at> getstate.dev>, =guix-patches <at> gnu.org
Subject: QA for 74057
Date: Fri,  1 Nov 2024 04:27:13 +0300

Review: 
	* submission: checked commit format, synopsis and description
	* submission: license, patch applies cleanly
	* functionality: test installed, guix lint is clean
	* code: checked style to packages around it
	* added: Reviewed-by commit trailer
	* re-roll to trigger QA build

Wiktor Żelazny (1):
  gnu: Add python-green.

 gnu/packages/python-check.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)


base-commit: 6e50b0c56a8cc767bd3acb26638f78c450bde718
-- 
2.46.0

Message #13 received at 74057 <at> debbugs.gnu.org (full text, mbox):

From: get-state <mazin <at> getstate.dev>
To: 74057 <at> debuggs.gnu.org,
	74057 <at> debbugs.gnu.org
Cc: Wiktor Żelazny <wz <at> freeshell.de>, =guix-patches <at> gnu.org,
 get-state <mazin <at> getstate.dev>
Subject: [PATCH v2 1/1] gnu: Add python-green.
Date: Fri,  1 Nov 2024 04:27:14 +0300

From: Wiktor Żelazny <wz <at> freeshell.de>

* gnu/packages/python-check.scm (python-green): New variable.

Change-Id: I554e8a635ff51413c79e3834fc1b88b34bbda84b
Signed-off-by: get-state <mazin <at> getstate.dev>
---
 gnu/packages/python-check.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/python-check.scm b/gnu/packages/python-check.scm
index ba66b081a5..3d181c8f7e 100644
--- a/gnu/packages/python-check.scm
+++ b/gnu/packages/python-check.scm
@@ -3003,3 +3003,27 @@ (define-public python-vulture
 dead code.  Also, code that is only called implicitly may be reported as
 unused.")
     (license license:expat)))
+
+(define-public python-green
+  (package
+    (name "python-green")
+    (version "4.0.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "green" version))
+       (sha256
+        (base32 "1cd62nbn5dvlpnsyplp6cb24wd230san8dpm6pnl99n2kwzpq1m4"))))
+    (build-system pyproject-build-system)
+    ;; python-coverage both in requirements.txt and requirements-dev.txt
+    (propagated-inputs (list python-colorama python-coverage python-lxml
+                             python-unidecode))
+    (native-inputs (list python-black python-django python-mypy
+                         python-testtools))
+    (home-page "https://github.com/CleanCut/green")
+    (synopsis "Clean, colorful, fast python test runner")
+    (description
+     "@code{green} is a python test runner which in addition to
+being clean, colorful and fast describes itself as powerful, traditional,
+descriptive, convenient, thorough, embedded, modern, portable and living.")
+    (license license:expat)))
-- 
2.46.0

Message #22 received at 74057 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: get-state <mazin <at> getstate.dev>
Cc: Wiktor Żelazny <wz <at> freeshell.de>,
 Sharlatan Hellseher <sharlatanus <at> gmail.com>,
 Munyoki Kilyungi <me <at> bonfacemunyoki.com>, 74057-done <at> debuggs.gnu.org,
 Lars-Dominik Braun <lars <at> 6xq.net>, 74057 <at> debbugs.gnu.org,
 =guix-patches <at> gnu.org, Marius Bakke <marius <at> gnu.org>,
 Tanguy Le Carrour <tanguy <at> bioneland.org>, jgart <jgart <at> dismail.de>
Subject: Re: [bug#74057] [PATCH v2 1/1] gnu: Add python-green.
Date: Fri, 01 Nov 2024 22:58:46 +0900

Hi,

get-state <mazin <at> getstate.dev> writes:

> From: Wiktor Żelazny <wz <at> freeshell.de>
>
> * gnu/packages/python-check.scm (python-green): New variable.
>
> Change-Id: I554e8a635ff51413c79e3834fc1b88b34bbda84b
> Signed-off-by: get-state <mazin <at> getstate.dev>

This is a cool collaboration :-).  I believe the correct trailer to
denote a review should be 'Reviewed-by: ...'.

> ---
>  gnu/packages/python-check.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/python-check.scm b/gnu/packages/python-check.scm
> index ba66b081a5..3d181c8f7e 100644
> --- a/gnu/packages/python-check.scm
> +++ b/gnu/packages/python-check.scm
> @@ -3003,3 +3003,27 @@ (define-public python-vulture
>  dead code.  Also, code that is only called implicitly may be reported as
>  unused.")
>      (license license:expat)))
> +
> +(define-public python-green
> +  (package
> +    (name "python-green")
> +    (version "4.0.2")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "green" version))
> +       (sha256
> +        (base32 "1cd62nbn5dvlpnsyplp6cb24wd230san8dpm6pnl99n2kwzpq1m4"))))
> +    (build-system pyproject-build-system)
> +    ;; python-coverage both in requirements.txt and requirements-dev.txt
> +    (propagated-inputs (list python-colorama python-coverage python-lxml
> +                             python-unidecode))
> +    (native-inputs (list python-black python-django python-mypy
> +                         python-testtools))
> +    (home-page "https://github.com/CleanCut/green")
> +    (synopsis "Clean, colorful, fast python test runner")
> +    (description
> +     "@code{green} is a python test runner which in addition to
> +being clean, colorful and fast describes itself as powerful, traditional,
> +descriptive, convenient, thorough, embedded, modern, portable and living.")
> +    (license license:expat)))

I've capitalized Python, adjusted the trailer and did a few improvements
to the description/style:

--8<---------------cut here---------------start------------->8---
1 file changed, 32 insertions(+), 9 deletions(-)
gnu/packages/python-check.scm | 41 ++++++++++++++++++++++++++++++++---------

modified   gnu/packages/python-check.scm
@@ -3015,15 +3015,38 @@ (define-public python-green
        (sha256
         (base32 "1cd62nbn5dvlpnsyplp6cb24wd230san8dpm6pnl99n2kwzpq1m4"))))
     (build-system pyproject-build-system)
-    ;; python-coverage both in requirements.txt and requirements-dev.txt
-    (propagated-inputs (list python-colorama python-coverage python-lxml
-                             python-unidecode))
-    (native-inputs (list python-black python-django python-mypy
-                         python-testtools))
+    (native-inputs
+     (list python-black
+           python-django
+           python-mypy
+           python-testtools))
+    ;; The python-coverage dependency appears both in requirements.txt and
+    ;; requirements-dev.txt.
+    (propagated-inputs
+     (list python-colorama
+           python-coverage
+           python-lxml
+           python-unidecode))
     (home-page "https://github.com/CleanCut/green")
-    (synopsis "Clean, colorful, fast python test runner")
+    (synopsis "Clean, colorful, fast Python test runner")
     (description
-     "@code{green} is a python test runner which in addition to
-being clean, colorful and fast describes itself as powerful, traditional,
-descriptive, convenient, thorough, embedded, modern, portable and living.")
+     "@code{green} is a Python test runner that describes itself as:
+@table @emph
+@item Clean
+Low redundancy in output.  Result statistics for each test is vertically aligned.
+@item Colorful
+Terminal output makes good use of color when the terminal supports it.
+@item Fast
+Tests run in independent processes (one per processor by default).
+@item Powerful
+Multi-target and auto-discovery support.
+@item Traditional
+It uses the normal @code{unittest} classes and methods.
+@item Descriptive
+Multiple verbosity levels, from just dots to full docstring output.
+@item Convenient
+Bash-completion and ZSH-completion of options and test targets.
+@item Thorough
+Built-in integration with @url{http://nedbatchelder.com/code/coverage/, coverage}.
+@end table")
     (license license:expat)))

[back]
--8<---------------cut here---------------end--------------->8---

And pushed as commit 08dc72473b.

Thanks to both of you!  Closing.

-- 
Maxim

Message #27 received at 74057-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 74057-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add python-green.
Date: Sun, 03 Nov 2024 12:20:24 +0000

[Message part 1 (text/plain, inline)]

Closing the issue to clean up from QA.

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.