GNU bug report logs - #74058
[PATCH 0/2] [important] Set postgresql default value to #f and warn users.

Previous Next

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 74058 <at> debbugs.gnu.org
Subject: [bug#74058] [PATCH 1/2] gnu: postgresql-configuration: Set default postgresql to #f.
Date: Wed, 06 Nov 2024 17:29:27 +0100

Hi,

Nicolas Graves <ngraves <at> ngraves.fr> skribis:

> * gnu/services/databases.scm (postgresql-configuration)[postgresql]:
> Set default to #f.
> (postgresql-services): Revert default to postgresql-10 (rationale: We
                     ^
No ‘s’.

>  (define-record-type* <postgresql-configuration>
>    postgresql-configuration make-postgresql-configuration
>    postgresql-configuration?
> -  (postgresql         postgresql-configuration-postgresql ;file-like
> -                      (default postgresql))
> +  ;; Setting it to #f ensures that the user sets its current postgresql
> +  ;; explicitely.  Since major upgrades currently require a manual migration
> +  ;; of the database, this way the user is responsible for upgrading properly.
> +  ;; MAYBE TODO: Write an action to automatically upgrade in Guix.
> +  (postgresql         postgresql-configuration-postgresql ;file-like or #f
> +                      (default #f))

How about having *no* default value in that case?  That way, existing
user configs will just fail to build, forcing users to act on it.
(Leaving it to #f would instead result in obscure backtraces.)

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.