GNU bug report logs - #74037
[PATCH 0/2] Remove outdated assimp-5.0 package.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74037 in the body.
You can then email your comments to 74037 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: guix-patches <at> gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>
Subject: [PATCH 0/2] Remove outdated assimp-5.0 package.
Date: Sun, 27 Oct 2024 00:35:02 +0200

Nicolas Graves (2):
  gnu: sbcl-classimp: Update to 0.0.0-1.6c74f38.
  gnu: Remove assimp-5.0.

 gnu/packages/graphics.scm | 14 --------------
 gnu/packages/lisp-xyz.scm | 29 +++++++----------------------
 2 files changed, 7 insertions(+), 36 deletions(-)

-- 
2.46.0

Message #8 received at 74037 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 74037 <at> debbugs.gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>
Subject: [PATCH 1/2] gnu: sbcl-classimp: Update to 0.0.0-1.6c74f38.
Date: Sun, 27 Oct 2024 00:46:07 +0200

* gnu/packages/lisp-xyz.scm
(sbcl-classimp): Update to 0.0.0-1.6c74f38.
[inputs]: Replace assimp-5.0 by assimp.
[arguments]<#:phases>: Adapt phase 'patch-assimp-lib-path.

(cl-classimp): Simplify.
(ecl-classimp): Simplify.
---
 gnu/packages/lisp-xyz.scm | 29 +++++++----------------------
 1 file changed, 7 insertions(+), 22 deletions(-)

diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index 16b1b8d873..d93c67ca5d 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -10857,8 +10857,8 @@ (define-public ecl-class-options
   (sbcl-package->ecl-package sbcl-class-options))
 
 (define-public sbcl-classimp
-  (let ((commit "d82a14c59bc733f89a1ea0b3447ebedddce5756e")
-        (revision "0"))
+  (let ((commit "6c74f3808e00781a2662f37ddc26ccbbf2687b6b")
+        (revision "1"))
     (package
       (name "sbcl-classimp")
       (version (git-version "0.0.0" revision commit))
@@ -10870,7 +10870,7 @@ (define-public sbcl-classimp
                (commit commit)))
          (file-name (git-file-name "cl-classimp" version))
          (sha256
-          (base32 "0pbnz6cf1zb2ayk4kbw0gphjb8nflnjns2rwhv86jz0kf0z1hqha"))))
+          (base32 "1sq34s5yrljh7fffllsscay7xi11lg03alrkyrh6xfwa2w7cnqmx"))))
       (build-system asdf-build-system/sbcl)
       (arguments
        (list
@@ -10880,9 +10880,9 @@ (define-public sbcl-classimp
               (lambda* (#:key inputs #:allow-other-keys)
                 (substitute* "library.lisp"
                   (("libassimp.so.5" _)
-                   (search-input-file inputs "/lib/libassimp.so.5.0.0"))))))))
+                   (search-input-file inputs "/lib/libassimp.so.5"))))))))
       (inputs
-       (list assimp-5.0
+       (list assimp
              sbcl-cffi
              sbcl-split-sequence))
       (home-page "https://github.com/3b/classimp")
@@ -10892,26 +10892,11 @@ (define-public sbcl-classimp
 Import} library for Common Lisp.")
       (license license:expat))))
 
-;; FIXME: The cl and ecl packages get the latest version of assimp as
-;; dependency instead of the one specified in the sbcl package. Specifying
-;; the dependencies explicitly works around the issue.
 (define-public cl-classimp
-  (let ((pkg (sbcl-package->cl-source-package sbcl-classimp)))
-    (package
-      (inherit pkg)
-      (inputs
-       (list assimp-5.0
-             cl-cffi
-             cl-split-sequence)))))
+  (sbcl-package->cl-source-package sbcl-classimp))
 
 (define-public ecl-classimp
-  (let ((pkg (sbcl-package->ecl-package sbcl-classimp)))
-    (package
-      (inherit pkg)
-      (inputs
-       (list assimp-5.0
-             ecl-cffi
-             ecl-split-sequence)))))
+  (sbcl-package->ecl-package sbcl-classimp))
 
 (define-public sbcl-clavier
   (let ((commit "9b1424eaad131e114a45b400784079124b5e2321")
-- 
2.46.0

Message #11 received at 74037 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 74037 <at> debbugs.gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>
Subject: [PATCH 2/2] gnu: Remove assimp-5.0.
Date: Sun, 27 Oct 2024 00:46:08 +0200

This package is outdated, not used anymore in Guix and has a CVE.

* gnu/packages/graphics.scm (assimp-5.0): Delete variable.
---
 gnu/packages/graphics.scm | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/gnu/packages/graphics.scm b/gnu/packages/graphics.scm
index c12516383b..8686cac7f7 100644
--- a/gnu/packages/graphics.scm
+++ b/gnu/packages/graphics.scm
@@ -688,20 +688,6 @@ (define-public assimp
 more.")
     (license license:bsd-3)))
 
-(define-public assimp-5.0
-  (package
-    (inherit assimp)
-    (version "5.0.0")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://github.com/assimp/assimp")
-                    (commit (string-append "v" version))))
-              (file-name (git-file-name "assimp" version))
-              (sha256
-               (base32
-                "1w2484lg823bql7lpfq84vnsfsnag5v65qrbphslj866z9ia68l7"))))))
-
 (define-public mikktspace
   ;; The latest commit is used as there is no release.
   (let ((commit   "3e895b49d05ea07e4c2133156cfa94369e19e409")
-- 
2.46.0

Message #16 received at 74037-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 74037-done <at> debbugs.gnu.org
Cc: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
Subject: Close
Date: Mon, 28 Oct 2024 09:50:00 +0100

Patches applied by Zheng Junjie, closing issue.

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.