GNU bug report logs - #74036
[PATCH 0/2] Remove outdated faust-0.9.67 package.

Previous Next

Package: guix-patches;

Reported by: Nicolas Graves <ngraves <at> ngraves.fr>

Date: Sat, 26 Oct 2024 22:35:01 UTC

Severity: normal

Tags: patch

Done: Sharlatan Hellseher <sharlatanus <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74036 in the body.
You can then email your comments to 74036 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#74036; Package guix-patches. (Sat, 26 Oct 2024 22:35:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Nicolas Graves <ngraves <at> ngraves.fr>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 26 Oct 2024 22:35:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: guix-patches <at> gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>
Subject: [PATCH 0/2] Remove outdated faust-0.9.67 package.
Date: Sun, 27 Oct 2024 00:33:00 +0200
Nicolas Graves (2):
  gnu: sorcer: Update to 1.1.3-2.94107b2.
  gnu: Remove faust-0.9.67.

 gnu/packages/audio.scm | 34 ----------------------------------
 gnu/packages/music.scm | 14 +++++---------
 2 files changed, 5 insertions(+), 43 deletions(-)

-- 
2.46.0





Information forwarded to guix-patches <at> gnu.org:
bug#74036; Package guix-patches. (Sat, 26 Oct 2024 22:47:01 GMT) Full text and rfc822 format available.

Message #8 received at 74036 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 74036 <at> debbugs.gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>
Subject: [PATCH 1/2] gnu: sorcer: Update to 1.1.3-2.94107b2.
Date: Sun, 27 Oct 2024 00:45:31 +0200
* gnu/packages/music.scm (sorcer): Update to 1.1.3-2.94107b2.
[arguments]<#:phases>: Remove 'remove-architecture-specific-flags
phase. Adapt 'build-faust-sources to faust-2.
[native-inputs]: Replace faust-0.9.67 by faust-2. Add which.
---
 gnu/packages/music.scm | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 548836abeb..92283d0218 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -5837,11 +5837,11 @@ (define-public fabla
     (license license:gpl2+)))
 
 (define-public sorcer
-  (let ((revision "1")
+  (let ((revision "2")
         ;; The last release was in 2016.  Since then a couple of commits have
         ;; been added to fix build problems, so we take this arbitrary recent
         ;; commit.
-        (commit "cc7f6f58af3188a8620b90fdad6e8ca5d026f543"))
+        (commit "94107b26e3e00e32504c8fb3fbf7572514d3b6bc"))
     (package
       (name "sorcer")
       (version (git-version "1.1.3" revision commit))
@@ -5853,7 +5853,7 @@ (define-public sorcer
                 (file-name (git-file-name name version))
                 (sha256
                  (base32
-                  "0ryaglp2pzln2bm0pwc5p9lb2nk0x4wmrs4c4cp6d2m2hhk82yk7"))
+                  "0md3d9h63ngrlh53mj1fmwhmnlxr7bqzpfb3wk9427v5n0y6yn48"))
                 (snippet
                  '(delete-file "faust/main.cpp"))))
       (build-system cmake-build-system)
@@ -5861,18 +5861,14 @@ (define-public sorcer
        `(#:tests? #f                    ;no tests included
          #:phases
          (modify-phases %standard-phases
-           (add-after 'unpack 'remove-architecture-specific-flags
-             (lambda _
-               (substitute* "CMakeLists.txt"
-                 (("-msse2 -mfpmath=sse") ""))))
            (add-after 'unpack 'build-faust-sources
              (lambda* (#:key inputs #:allow-other-keys)
                (with-directory-excursion "faust"
                  (invoke "faust" "-i"
-                         "-a" "lv2synth.cpp"
+                         "-a" "lv2.cpp"
                          "-o" "main.cpp" "main.dsp")))))))
       (inputs (list boost lv2 ntk))
-      (native-inputs (list faust-0.9.67 pkg-config))
+      (native-inputs (list faust-2 pkg-config which))
       (home-page "http://openavproductions.com/sorcer/")
       (synopsis "Wavetable LV2 plugin synth")
       (description "Sorcer is a wavetable LV2 plugin synthesizer, targeted at
-- 
2.46.0





Information forwarded to guix-patches <at> gnu.org:
bug#74036; Package guix-patches. (Sat, 26 Oct 2024 22:47:02 GMT) Full text and rfc822 format available.

Message #11 received at 74036 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 74036 <at> debbugs.gnu.org
Cc: Nicolas Graves <ngraves <at> ngraves.fr>
Subject: [PATCH 2/2] gnu: Remove faust-0.9.67.
Date: Sun, 27 Oct 2024 00:45:32 +0200
* gnu/packages/audio.scm (faust-0.9.67): Delete variable.
---
 gnu/packages/audio.scm | 34 ----------------------------------
 1 file changed, 34 deletions(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 1ab0cbdd05..1bb7c1c314 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -2231,40 +2231,6 @@ (define-public faust
      "Faust is a programming language for realtime audio signal processing.")
     (license license:gpl2+)))
 
-;; This version is needed to build older synths that require the lv2synth.cpp
-;; architecture file, such as sorcer.
-(define-public faust-0.9.67
-  (package
-    (inherit faust)
-    (name "faust")
-    (version "0.9.67")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://github.com/grame-cncm/faust")
-                    (commit (string-append "v"
-                                           (string-map (lambda (c)
-                                                         (if (char=? c #\.) #\- c))
-                                                       version)))))
-              (file-name (git-file-name name version))
-              (sha256
-               (base32
-                "0856x666s6ymzk8v15f9gy402dbr8c9v2s40hyfadhraqljmqrm0"))
-              (snippet
-               ;; Remove prebuilt library
-               '(delete-file "architecture/android/libs/armeabi-v7a/libfaust_dsp.so"))))
-    (build-system gnu-build-system)
-    (arguments
-     (list
-      #:make-flags
-      #~(list (string-append "prefix=" #$output))
-      #:tests? #f
-      #:phases
-      '(modify-phases %standard-phases
-         ;; no "configure" script
-         (delete 'configure))))
-    (native-inputs (list unzip))))
-
 (define-public faust-2
   (package
     (inherit faust)
-- 
2.46.0





Reply sent to Sharlatan Hellseher <sharlatanus <at> gmail.com>:
You have taken responsibility. (Sun, 03 Nov 2024 12:33:02 GMT) Full text and rfc822 format available.

Notification sent to Nicolas Graves <ngraves <at> ngraves.fr>:
bug acknowledged by developer. (Sun, 03 Nov 2024 12:33:02 GMT) Full text and rfc822 format available.

Message #16 received at 74036-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 74036-done <at> debbugs.gnu.org
Subject: [PATCH 0/2] Remove outdated faust-0.9.67 package.
Date: Sun, 03 Nov 2024 12:31:11 +0000
[Message part 1 (text/plain, inline)]
Hi,

Thanks for the patches.

I've applied, build and lint it locally on x86_64 machine all passed
just well!

Pushed a0cb16ddd7..8964dfdb84 to master.

--
Oleg
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 02 Dec 2024 12:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 200 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.