GNU bug report logs - #74011
[PATCH] gnu: prrte: Record the absolute file name of ‘prted’.

Previous Next

Package: guix-patches;

Reported by: Ludovic Courtès <ludo <at> gnu.org>

Date: Fri, 25 Oct 2024 10:48:02 UTC

Severity: normal

Tags: patch

Done: Andreas Enge <andreas <at> enge.fr>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andreas Enge <andreas <at> enge.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#74011: closed ([PATCH] gnu: prrte: Record the absolute file
 name of ‘prted’.)
Date: Mon, 28 Oct 2024 09:25:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Mon, 28 Oct 2024 10:24:01 +0100
with message-id <Zx9YMQRWdU3arOwp <at> jurong>
and subject line Close
has caused the debbugs.gnu.org bug report #74011,
regarding [PATCH] gnu: prrte: Record the absolute file name of ‘prted’.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
74011: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74011
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Ludovic Courtès <ludovic.courtes <at> inria.fr>
Subject: [PATCH] gnu: prrte: Record the absolute file name of ‘prted’.
Date: Fri, 25 Oct 2024 12:46:24 +0200
From: Ludovic Courtès <ludovic.courtes <at> inria.fr>

Previously a command like:

  guix shell --pure openmpi <at> 5 openssh intel-mpi-benchmarks \
    --with-input=openmpi <at> 4=openmpi <at> 5 slurm -- \
    salloc -N2 -- mpirun -np 2 --map-by node IMB-MPI1 PingPong

would silently fail due to ‘prted’ not being found in $PATH.

* gnu/packages/parallel.scm (prrte)[arguments]: Add
‘patch-prted-reference’ phase.

Change-Id: Iff30cb5a4dcc9e9cfe6638d518ee4f19561289a0
---
 gnu/packages/parallel.scm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/parallel.scm b/gnu/packages/parallel.scm
index 202a98b2bc..85f8a114c3 100644
--- a/gnu/packages/parallel.scm
+++ b/gnu/packages/parallel.scm
@@ -727,7 +727,15 @@ (define-public prrte
                     (("_ABSOLUTE")
                      "")
                     (("PRTE_CONFIGURE_CLI")
-                     "\"[elided to reduce closure]\"")))))
+                     "\"[elided to reduce closure]\""))))
+              (add-after 'unpack 'patch-prted-reference
+                (lambda _
+                  ;; Record the absolute file name of 'prted' instead of
+                  ;; assuming it will be found in $PATH at run time.
+                  (substitute* "src/runtime/prte_mca_params.c"
+                    (("prte_launch_agent =.*")
+                     (string-append "prte_launch_agent = \""
+                                    #$output "/bin/prted\";\n"))))))
 
           #:disallowed-references (list (canonical-package gcc))))
    (inputs (list libevent

base-commit: a1714de3aa4f60d211c166876c3515f96384b0c7
-- 
2.46.0



[Message part 3 (message/rfc822, inline)]
From: Andreas Enge <andreas <at> enge.fr>
To: 74011-done <at> debbugs.gnu.org
Subject: Close
Date: Mon, 28 Oct 2024 10:24:01 +0100
The patch passes QA. I am pushing it on behalf of the author who is AWK.

Andreas



This bug report was last modified 247 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.