GNU bug report logs - #74011
[PATCH] gnu: prrte: Record the absolute file name of ‘prted’.

Previous Next

Package: guix-patches;

Reported by: Ludovic Courtès <ludo <at> gnu.org>

Date: Fri, 25 Oct 2024 10:48:02 UTC

Severity: normal

Tags: patch

Done: Andreas Enge <andreas <at> enge.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 74011 in the body.
You can then email your comments to 74011 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#74011; Package guix-patches. (Fri, 25 Oct 2024 10:48:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Ludovic Courtès <ludo <at> gnu.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 25 Oct 2024 10:48:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Ludovic Courtès <ludovic.courtes <at> inria.fr>
Subject: [PATCH] gnu: prrte: Record the absolute file name of ‘prted’.
Date: Fri, 25 Oct 2024 12:46:24 +0200
From: Ludovic Courtès <ludovic.courtes <at> inria.fr>

Previously a command like:

  guix shell --pure openmpi <at> 5 openssh intel-mpi-benchmarks \
    --with-input=openmpi <at> 4=openmpi <at> 5 slurm -- \
    salloc -N2 -- mpirun -np 2 --map-by node IMB-MPI1 PingPong

would silently fail due to ‘prted’ not being found in $PATH.

* gnu/packages/parallel.scm (prrte)[arguments]: Add
‘patch-prted-reference’ phase.

Change-Id: Iff30cb5a4dcc9e9cfe6638d518ee4f19561289a0
---
 gnu/packages/parallel.scm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/parallel.scm b/gnu/packages/parallel.scm
index 202a98b2bc..85f8a114c3 100644
--- a/gnu/packages/parallel.scm
+++ b/gnu/packages/parallel.scm
@@ -727,7 +727,15 @@ (define-public prrte
                     (("_ABSOLUTE")
                      "")
                     (("PRTE_CONFIGURE_CLI")
-                     "\"[elided to reduce closure]\"")))))
+                     "\"[elided to reduce closure]\""))))
+              (add-after 'unpack 'patch-prted-reference
+                (lambda _
+                  ;; Record the absolute file name of 'prted' instead of
+                  ;; assuming it will be found in $PATH at run time.
+                  (substitute* "src/runtime/prte_mca_params.c"
+                    (("prte_launch_agent =.*")
+                     (string-append "prte_launch_agent = \""
+                                    #$output "/bin/prted\";\n"))))))
 
           #:disallowed-references (list (canonical-package gcc))))
    (inputs (list libevent

base-commit: a1714de3aa4f60d211c166876c3515f96384b0c7
-- 
2.46.0





Reply sent to Andreas Enge <andreas <at> enge.fr>:
You have taken responsibility. (Mon, 28 Oct 2024 09:25:02 GMT) Full text and rfc822 format available.

Notification sent to Ludovic Courtès <ludo <at> gnu.org>:
bug acknowledged by developer. (Mon, 28 Oct 2024 09:25:02 GMT) Full text and rfc822 format available.

Message #10 received at 74011-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 74011-done <at> debbugs.gnu.org
Subject: Close
Date: Mon, 28 Oct 2024 10:24:01 +0100
The patch passes QA. I am pushing it on behalf of the author who is AWK.

Andreas





bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 25 Nov 2024 12:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 200 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.