GNU bug report logs - #73953
Add new emacs-greader-mode package definition.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#73953: closed (Add new emacs-greader-mode package definition.)
Date: Thu, 24 Oct 2024 13:20:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 24 Oct 2024 15:18:48 +0200
with message-id <87ikthmyfb.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#73953] Add new emacs-greader-mode package definition.
has caused the debbugs.gnu.org bug report #73953,
regarding Add new emacs-greader-mode package definition.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
73953: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=73953
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Yuval Langer <yuvallangerontheroad <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: Add new emacs-greader-mode package definition.
Date: Tue, 22 Oct 2024 20:01:50 +0300

[Message part 3 (text/plain, inline)]

Hi,

attached is a Guix package definition for Michelangelo Rodriguez's
Gnamù reader (greader) text to speech minor mode, version 0.11.18 .

Please review.

Thank you,
Yuval Langer.

[0001-gnu-Add-emacs-greader-mode.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Yuval Langer <yuvallangerontheroad <at> gmail.com>
Cc: 73953-done <at> debbugs.gnu.org
Subject: Re: [bug#73953] Add new emacs-greader-mode package definition.
Date: Thu, 24 Oct 2024 15:18:48 +0200

Hello,

Yuval Langer <yuvallangerontheroad <at> gmail.com> writes:

> attached is a Guix package definition for Michelangelo Rodriguez's
> Gnamù reader (greader) text to speech minor mode, version 0.11.18.

I applied your patch with a few tweaks. Thanks!

> +(define-public emacs-greader-mode
> +  (let ((commit "e163aec6109ba24ec543f087d9be7bf6b6efa389")
> +        (revision "1")
> +        (git-repository-url
> +         "https://gitlab.com/michelangelo-rodriguez/greader"))

I set the repository URL the usual way, in both `origin' and `home-page'
fields.

> +    (package
> +      (name "emacs-greader-mode")
> +      (version (git-version "0.11.18" revision commit))
> +      (home-page git-repository-url)

Nitpick: I moved that field above synopsis, to be on par with other packages.

> +      (synopsis
> +       "Gnamù Reader - greader-mode, send buffer contents to a speech engine")
> +      (description
> +       "Greader is a module that allows you to send any emacs buffer to a TTS.
> +A text-to-speech like engine @code{espeak-ng} or @code{speech-dispatcher} are
> +already supported, plus limited bakend support native to macOS.  The
> +mode supports timer reading, automatic scrolling of buffers in modes
> +like @code{info-mode}, repeating reading of regions or the whole buffer,
> +includes a feature to facilitate the compilation of espeak-ng
> +pronunciations, and other features.")

I slightly tweaked the synopsis and the description.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.