GNU bug report logs - #73952
30.0.91; [PATCH] Fix error when an Eshell glob has no results and 'eshell-glob-splice-results' is t

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 73952 in the body.
You can then email your comments to 73952 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.91; [PATCH] Fix error when an Eshell glob has no results and
 'eshell-glob-splice-results' is t
Date: Tue, 22 Oct 2024 09:57:42 -0700

[Message part 1 (text/plain, inline)]

X-Debbugs-CC: eliz <at> gnu.org

Starting from "emacs -Q -f eshell":

  ~ $ (setq eshell-glob-splice-results t)
  t
  ~ $ echo /ssh:localhost:~/file.txt
  /ssh:localhost:~/file.txt
  ~ $ echo /ssh:localhost:~/file.txt
  Wrong type argument: listp, "/ssh:localhost:~/file.txt"

The third command should have the same result as the second (the second 
works because Tramp isn't loaded yet at the time).

This is a bug in a new Eshell feature in Emacs 30 and thankfully has an 
easy fix (see attached). Eli, is this ok for the release branch? I added 
a regression test for this too.

[0001-Fix-error-when-splicing-Eshell-globs-and-a-glob-expa.patch (text/plain, attachment)]

Message #8 received at 73952 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 73952 <at> debbugs.gnu.org
Subject: Re: bug#73952: 30.0.91;
 [PATCH] Fix error when an Eshell glob has no results and
 'eshell-glob-splice-results' is t
Date: Tue, 22 Oct 2024 20:43:43 +0300

> Cc: eliz <at> gnu.org
> Date: Tue, 22 Oct 2024 09:57:42 -0700
> From: Jim Porter <jporterbugs <at> gmail.com>
> 
>    ~ $ (setq eshell-glob-splice-results t)
>    t
>    ~ $ echo /ssh:localhost:~/file.txt
>    /ssh:localhost:~/file.txt
>    ~ $ echo /ssh:localhost:~/file.txt
>    Wrong type argument: listp, "/ssh:localhost:~/file.txt"
> 
> The third command should have the same result as the second (the second 
> works because Tramp isn't loaded yet at the time).
> 
> This is a bug in a new Eshell feature in Emacs 30 and thankfully has an 
> easy fix (see attached). Eli, is this ok for the release branch?

Yes, thanks.

Message #13 received at 73952-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 73952-done <at> debbugs.gnu.org
Subject: Re: bug#73952: 30.0.91; [PATCH] Fix error when an Eshell glob has no
 results and 'eshell-glob-splice-results' is t
Date: Tue, 22 Oct 2024 14:31:58 -0700

On 10/22/2024 10:43 AM, Eli Zaretskii wrote:
>> Cc: eliz <at> gnu.org
>> Date: Tue, 22 Oct 2024 09:57:42 -0700
>> From: Jim Porter <jporterbugs <at> gmail.com>
>>
>> This is a bug in a new Eshell feature in Emacs 30 and thankfully has an
>> easy fix (see attached). Eli, is this ok for the release branch?
> 
> Yes, thanks.

Thanks. Merged to the release branch as b7a375f5c49, and closing this now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.